[network] Use ss instead of netstat on linux
#1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Can you write a test that checks that the metrics collected are equivalent ? |
|
Also can you switch to this helper ? https://github.com/DataDog/dd-agent/blob/master/utils/subprocess_output.py It will be easier to debug and is safer to use |
olivielpeau
force-pushed
the
olivielpeau/network-use-ss
branch
from
91e529e to
00ae20d
Compare
`netstat` is deprecated on many distributions, `ss` is its replacement. It brings perf improvements especially on systems that have lots of connections. We still use `netstat` as a fallback if `ss` is not installed.
olivielpeau
force-pushed
the
olivielpeau/network-use-ss
branch
from
00ae20d to
1159001
Compare
|
LGTM |
olivielpeau
added a commit
that referenced
this pull request
Sep 24, 2015
[network] Use `ss` instead of `netstat` on linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netstatis deprecated on many distributions,ssis its replacement and is present by default in thePATHon most of the distributions that I've tested (CentOS >= 6, Ubuntu >= 12.04, but not on CentOS 5).We still fallback to
netstatifssis not installed.Addresses #1156
I've also checked that
subprocess.Popendoesn't hang withstdout=PIPE: as long as we use it withcommunicate()(which we do here) we should be fine.