haproxy- grabbing 'server' name instead of host name

[MisterRayCo]

might be a tag misreported, possibly in this logic:
https://github.com/DataDog/dd-agent/blob/master/checks.d/haproxy.py#L151-L154

[conorbranagan]

It looks like the real problem is that we're treating HAProxy backends as hosts that are actually running HAProxy. This works in our specific setup - where we have haproxy running on all of the backend hosts - but this is unusual and would actually be considered "wrong" in many cases.

We should only consider the host that's returning the stats as the host that has the haproxy metrics and give the metrics tags of "backend:$hostname" for every backend that's listed in the stats.

[remh]

The fix is pretty easy. But how should we manage this change with the existing users ?
There is a lot of users using the haproxy integration.
Changing the way it's behaving will break their dashboards.
Should we release this with 4.0.0 ?

[miketheman]

I'm going to go with the opinion that since this is a bug in the way we collected data, and people have complained about nodes not having the DD agent appearing in their infrastructure lists, and potentially being charged for, this isn't a backwards-breaking feature, and doesn't need a major revision bump.

[olidb2]

Yet...
1- let's pick our two biggest customers using HAProxy,
2- understand beforehands how it will impact them (write it down)
3- communicate it to them if needed (Ray, your call)
4- check that after upgrade their behavior corresponds to what we expected.

On Fri, Sep 6, 2013 at 8:53 AM, Mike Fiedler [email protected]:

I'm going to go with the opinion that since this is a bug in the way we
collected data, and people have complained about nodes not having the DD
agent appearing in their infrastructure lists, and potentially being
charged for, this isn't a backwards-breaking feature, and doesn't need a
major revision bump.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/617#issuecomment-23937563
.

[remh]

@MisterRayCo I made a list of the consequences of fixing that issue.
I'll follow up with you so we can reach a few customers and have their point of view on that.

[mrardon]

have there been any updates to this?

[alq666]

@mrardon we're testing the changes internally and plan to release this shortly.

[remh]

Fixed with agent 4.x