Support * globs in dogstream file configuration

[clofresh]

So that this will do the Right Thing(tm):

dogstreams: /var/log/mydir/*.log

[neopunisher]

+1

[gtaylor]

Bigtime! Trying to write some Ansible playbooks now, but the requirement that this directive only appear once is complicating things. Various roles require different dogstreams.

[gtaylor]

Pull request plus tests sent!

[gtaylor]

Took this to an even higher level in #1557 with a dogstreams.d feature (similar to conf.d and checks.d). You can drop YAML files in and wildcarding is supported.

[Nuxij]

+1000 I was just about to start work on making the dogstreams config support much better, but this guy has nailed it. Props to you @gtaylor

[gtaylor]

@joeasaurus It's a bit disappointing not to hear a peep from the Datadog maintainers, since this is IMO a glaring omission. I'm not sure whether to even waste the time rebasing this given the lack of response.

[Nuxij]

I for one would be most grateful.

[gtaylor]

Yeah, I just don't want to waste any more time on it if they aren't going to accept it. Feel free to encourage them to take a look at this if it's causing you pain in your usage case.

[R4wizard]

+1

[LeoCavaille]

@gtaylor thanks again for this new feature, sorry that we didn't have time to review it sooner. Let's get to it and review that for 5.4. If we need to put more work on it, we can help you do that.

[Nuxij]

@yannmh It seems to me as though you lost my fix to use dogstreams.d exclusively?

https://github.com/Aclima/dd-agent/pull/1/files

[yannmh]

Hi @joeasaurus,

Your fix is still on his way (#1557) and should be reviewed shortly. Thanks again for your contribution 😃

This specific issue was solved with #1550

[Nuxij]

Aaaah no worries, thanks :D