Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rudy/win dogstream #1056

Merged
merged 8 commits into from
Jul 24, 2014
Merged

Rudy/win dogstream #1056

merged 8 commits into from
Jul 24, 2014

Conversation

bunelr
Copy link
Contributor

@bunelr bunelr commented Jul 23, 2014

Fixes #887

Allows to use dogstreams on windows.
The issue was the parsing of the configuration file that was done by splitting on ':' which caused issue with windows C:... paths. '/' paths were also assumed in some places.

On my vm with win server 2012 r2, I could parse a log by specifying it's complete path, with a custom parser also specified by its path

@bunelr
Copy link
Contributor Author

bunelr commented Jul 24, 2014

Also ran on Ubuntu and on my mac

@remh
Copy link

remh commented Jul 24, 2014

👍

remh pushed a commit that referenced this pull request Jul 24, 2014
@remh remh merged commit 9bf005e into master Jul 24, 2014
@bunelr bunelr deleted the rudy/win-dogstream branch July 28, 2014 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dogstream doesn't work with windows full paths
2 participants