[tests] Improve tests for fluentd check. #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2015
|
|
||
| from tests.common import load_check | ||
| from checks import AgentCheck |
There was a problem hiding this comment.
A debug import ? (not used anywhere)
| self.assertServiceCheckOK(self.check.SERVICE_CHECK_NAME, | ||
| tags=['fluentd_host:localhost', 'fluentd_port:24220']) | ||
| for m in self.CHECK_GAUGES: | ||
| self.assertMetric('%s.%s' % (self.CHECK_NAME, m)) |
There was a problem hiding this comment.
You should also check the tags.
There was a problem hiding this comment.
Also, I know we don't really care about python 3 compatibility, but you should probably use format instead of %.
| metrics = check.get_metrics() | ||
| for m in metrics: | ||
| self.assertEquals(m[3]['tags'], ['type:forward']) | ||
| self.coverage_report() |
There was a problem hiding this comment.
You didn't test the service_check, the coverage report will fail.
hkaj
force-pushed
the
haissam/fluentd-update-test
branch
from
4a5e798 to
8fa5234
Compare
hkaj
force-pushed
the
haissam/fluentd-update-test
branch
from
8fa5234 to
bef8b45
Compare
hkaj
added a commit
that referenced
this pull request
May 19, 2015
[tests] Improve tests for fluentd check.
|
Changes Unknown when pulling bef8b45 on haissam/fluentd-update-test into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.