Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply image_repository tag to docker.containers.* #1787

Closed
wants to merge 1 commit into from

Conversation

optimality
Copy link

No description provided.

@remh
Copy link

remh commented Jul 27, 2015

Thanks a lot @optimality !
@hkaj @JohnLZeller can you have a look please ?

@remh remh added this to the 5.5.0 milestone Jul 27, 2015
@yannmh
Copy link
Member

yannmh commented Aug 7, 2015

Thanks a lot for your contribution @optimality.

We addressed this request in a previous PR #1691. It'll be part of the next agent released planned for mid August. Thanks again.

@yannmh yannmh closed this Aug 7, 2015
@optimality
Copy link
Author

This is a different feature. This is intended to apply the image_repository tag to docker.containers.running and docker.containers.stopped, which don't currently have that tag. The PR you referenced applies that tag to docker.mem.* and docker.cpu.*.

This feature will let us add running/stopped counts to our service dashboards, which we can't currently do.

@yannmh
Copy link
Member

yannmh commented Aug 7, 2015

Sorry for the confusion @optimality 😊, I am reopening the PR. @JohnLZeller will review it shortly.

@yannmh yannmh reopened this Aug 7, 2015
@yannmh yannmh modified the milestones: 5.6.0, 5.5.0 Aug 7, 2015
@optimality
Copy link
Author

Thanks! I can totally see how it looks just like #1691 at first glance 😸.

@remh remh modified the milestones: 5.5.0, 5.6.0 Aug 17, 2015
@remh remh self-assigned this Aug 17, 2015
@remh
Copy link

remh commented Aug 28, 2015

@optimality I'm closing this pull request. The docker check is being rewritten, so i'll make sure that this feature will be part of it.

@remh remh closed this Aug 28, 2015
@optimality
Copy link
Author

Cool, looking forward to the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants