[mongo] add tcmalloc metrics #1832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
tcmalloc
branch
2 times, most recently
from
9af741a to
9b2bc39
Compare
|
Thanks a lot @benmccann we'll review this for our 5.6.0 release! |
|
Thanks. Would we be able to get this in now that 5.5.0 has been released? |
yannmh
added a commit
that referenced
this pull request
Oct 16, 2015
Split the metric list in multiple parts: * `COMMON_METRICS`: default metrics to collect * `V2_ONLY_METRICS`: metrics available in MongoDB 2.x only * `TCMALLOC_METRICS`: TCMalloc memory allocator metrics It's easier to assess the check coverage in our CI, and gives more control on the level of metric collection. Create a `collect_tcmalloc_metrics` option (default to False). Extends #1832, thanks a lot @benmccann !
|
Hi @benmccann, Sincere apologies for the delay on this. Please let me know what you think about it 😄 |
yannmh
added a commit
that referenced
this pull request
Oct 16, 2015
Split the metric list in multiple parts: * `COMMON_METRICS`: default metrics to collect * `V2_ONLY_METRICS`: metrics available in MongoDB 2.x only * `TCMALLOC_METRICS`: TCMalloc memory allocator metrics It's easier to assess the check coverage in our CI, and gives more control on the level of metric collection. Create a `collect_tcmalloc_metrics` option (default to False). Extends #1832, thanks a lot @benmccann !
yannmh
added a commit
that referenced
this pull request
Oct 29, 2015
Split the metric list in multiple parts: * `COMMON_METRICS`: default metrics to collect * `V2_ONLY_METRICS`: metrics available in MongoDB 2.x only * `TCMALLOC_METRICS`: TCMalloc memory allocator metrics It's easier to assess the check coverage in our CI, and gives more control on the level of metric collection. Create a `collect_tcmalloc_metrics` option (default to False). Extends #1832, thanks a lot @benmccann !
urosgruber
pushed a commit
to urosgruber/dd-agent
that referenced
this pull request
Dec 23, 2015
Split the metric list in multiple parts: * `COMMON_METRICS`: default metrics to collect * `V2_ONLY_METRICS`: metrics available in MongoDB 2.x only * `TCMALLOC_METRICS`: TCMalloc memory allocator metrics It's easier to assess the check coverage in our CI, and gives more control on the level of metric collection. Create a `collect_tcmalloc_metrics` option (default to False). Extends DataDog#1832, thanks a lot @benmccann !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You will need MongoDB 3.2 or newer to benefit from this PR since that's when the tcmalloc metrics start being returned. This PR works just fine on older versions of MongoDB, but you won't get these new metrics.