[logging] Avoid initializing logging multiple times #1850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initialization of logging is usually done at the beginning of a python module. This can lead the init of logging to happen multiple times when a module that has already initialized it imports another module that also inits it, which causes the logs of the first module to be duplicated in the second module's logs. For instance agent.py imports jmxfetch.py, which causes the collector's logs to also end up in jmxfetch.py's logs. I don't think we ever want the init of logging to happen multiple times per process, hence this commit.
|
Superseded by #1852. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization of logging is usually done at the beginning of a python module. This can lead the init of logging to happen multiple times when a module that has already initialized it imports another module that also inits it, which causes the logs of the first module to be duplicated in the second module's logs.
For instance
agent.pyimportsjmxfetch.py, which causes the collector's logs to also end up injmxfetch.py's logs.I don't think we ever want the init of logging to happen multiple times per process, hence this commit.
Open for discussion as I'm not sure I'm aware of all the possible consequences of this change.