Checks.d

[conorbranagan]

Everything you could ever want from the agent.

[conorbranagan]

Still needs packaging.

[clofresh]

Are we splitting config out as well? Maybe it'd be better if the files were structured like:

/etc/datadog/checks.d/haproxy/haproxy.py
/etc/datadog/checks.d/haproxy/haproxy.yaml

[clutchski]

We should name this logger with name

[conorbranagan]

Which name?

[clutchski]

sorry __name__

[clutchski]

All in all, great stuff. I'm excited for this. Also, I'd like to see the "generic config" at some point too.

[conorbranagan]

@clofresh The structure I was thinking we'd follow was:

/etc/dd-agent/conf.d/haproxy.yaml

/usr/share/agent/checks.d/haproxy.py

The keeps all of the python modules in one place and the conf in one place.

[conorbranagan]

@clutchski @clofresh I made some decent changes to this pull, so it could probably use another look from you guys.

After a discussion with Matt P we came to the conclusion that it made more sense to send the full payload dict to the check instead of doing a ** and having it go as variables. The main reason that convinced me is if we ever had non-python-friendly names for a key, it would break things.

[conorbranagan]

Packaging is good now. It will put conf.d and checks.d in the right places. This should be good to go, pending any other things that come up in a review.