[mongo] Add WiredTiger metrics #1980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
force-pushed
the
yann/wiredtiger-option
branch
from
0433c67 to
7e7011a
Compare
| "tcmalloc.tcmalloc.transfer_cache_free_bytes": GAUGE, | ||
| } | ||
|
|
||
| WIREDTIGER_METRICS = { |
There was a problem hiding this comment.
not sure about these metric names...
There was a problem hiding this comment.
The metric names were created by MongoDB. We're simply collecting the metrics that they export. I think it'd be really confusing to remap them to new names because then for every metric we have to go back and figure out what the MongoDB name was to really understand what it's doing.
|
@yannmh let's talk about the metric names. Everything else is 👍 |
yannmh
force-pushed
the
yann/wiredtiger-option
branch
from
7e7011a to
33b328c
Compare
By default, the check collects a sample of metrics from MongoDB. The (optional) `additional_metrics` parameter instructs the check to collect additional metrics on specific topics. Available options are: * `durability` - Journaling-related operations and performance * `locks` - Locks * `metrics.commands` - Use of database commands * `tcmalloc` - TCMalloc memory allocator
[[email protected]] rebased on #1979 → `collect_wiredtiger_metrics` option.
yannmh
force-pushed
the
yann/wiredtiger-option
branch
from
33b328c to
78a6c92
Compare
|
Closing in favor of #2020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #1825 on #1979, to collect WiredTiger metrics behind a
additional_metricsoption.Thanks again @benmccann !