Add more "core" Linux metrics #2030
Conversation
|
@gphat Apologies for the delay here. We are mid prepping for the 5.6 release. We will get back to you shortly with feedback on the change. In the mean time would you mind having a gander at the failing tests? It looks like at least some of them are just style issues that should be quick to address. ./checks/system/unix.py:580:55: F812 list comprehension redefines 'line' from line 572 Thank you for being part of the Datadog community! |
|
Done! Fyi, that change was in existing code, not in something I touched. But a fix nonetheless! |
gphat
changed the title
gphat
force-pushed
the
add-some-new-system-metrics
branch
from
4bf0672 to
734465b
Compare
gphat
force-pushed
the
add-some-new-system-metrics
branch
from
9e82180 to
77b488a
Compare
| init_config: | ||
|
|
||
| instances: | ||
| - tags: [] |
There was a problem hiding this comment.
Can you add some comment here to say that the configuration it doesn't need any specific parameters ?
|
Done! Waiting on the |
| tags = instance.get('tags', []) | ||
|
|
||
| state_counts = collections.Counter( | ||
| uninterruptible=0, |
There was a problem hiding this comment.
The good thing about the Counter is that you don't need to initialize your keys at 0 :)
state_counts = Counter()would give you the same result
|
Fixed! :) |
|
Thanks Cory. |
gphat
force-pushed
the
add-some-new-system-metrics
branch
from
15c2bf9 to
feaa9fd
Compare
|
Squashed! Omg I just learned how to squash merge when I've already done merges in to the branch. It's an early Christmas! |
| from checks import AgentCheck | ||
| from utils.subprocess_output import get_subprocess_output | ||
| from collections import Counter | ||
| import subprocess |
gphat
force-pushed
the
add-some-new-system-metrics
branch
from
6ba6645 to
17ba278
Compare
|
Fixed and rebased for brevity. |
| def check(self, instance): | ||
| tags = instance.get('tags', []) | ||
|
|
||
| state_counts = Counter() |
There was a problem hiding this comment.
I know i'm the one who told you to use a Counter but i forgot that Counter were not available on python 2.6. Can you use a defaultdict(int) instead ?
|
Thanks @gphat ! Can you rebase against the latest version of master again please ? It should fix the zookeeper failing test. Also could you write a test for this integration please ? It should be pretty straigthforward. |
|
Hey @remh, does all that look right? I'm still getting failures, but they seem to be elsewhere. I will clean up the commits once you think it's ok. |
|
Friendly ping, @remh! |
|
Looks good to me @gphat ! Can you squash the commits and then i'll merge |
|
See #2202, I broke it when squash merging. Ugh. |
What's this PR do?
Adds some new system metrics:
Motivation
These metrics are used in our existing setup and, from what I can tell, are not available today in Datadog agent. We can get them from specific processes via
process.yaml, but not for the whole system!Notes
I originally tried to add this stuff to
unix.pybut I'm unable to determine how those metrics end up as things likesys.mem.freeand the like. So I settled on making a check that added the metrics I as after. I expect to add more.Most of these metrics feel very "core" to Linux and therefore seem suitable to be included in something like
unix.py. But for now I'll opt to take a conservative approach and assume this will just be a plugin. If you are not interested in having it in the agent, we'll just use it locally.Lemme know and thanks for looking!