Fixes IndexError from killing agent when no process table returned #3043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
The pull request moves the removal of the process table header into the try block above to prevent an IndexError from crashing the process. The general standard error will catch the IndexError and not require an additional error class
Motivation
We had a system that filled its disk so the output of the process table returned was empty and cause the process to fail. Other errors are caught when running the
ps
command so I figured why not catch this one at the same time ifps
command succeeds but nothing is returned.Testing Guidelines
I looked at the testing but I couldn't any tests that test this file. If I could get a pointer of where to look then I'd be happy to try to add in a test.
Additional Notes
Error from the logs: