local checks in /etc/dd-agent/checks.d/

[brettlangdon]

The idea here is to look in /etc/dd-agent/checks.d first when trying to load checks, this way we can deploy custom checks here instead of in the dd-agent install directory.

I tried to update the install/packaging scripts to add the checks.d directory, but I know I am missing some stuff (especially for the windows stuff). If someone could please advise.

[conorbranagan]

@brettlangdon Could we make the additional checks.d path configurable in datadog.conf, having it default to /etc/dd-agent/checks.d/?

Also I think it might be a bit cleaner if _get_checksd_path is just moved to _get_checksd_paths or something and we just return a list of check paths, versus calling it twice with an extra arg. We only call it once here and in a single test, so it wouldn't have to be changed all over the place or anything like that.

[clutchski]

cool idea. thanks for submitting.

[brettlangdon]

@conorbranagan, ok, take 2.

What I did is revert _{unix,windows}_checksd_path to return only a single path and then added a configuration parameter additional_checksd which defaults to /etc/dd-agent/checks.d for unix and the common data folder for windows.

[conorbranagan]

Thanks, that's perfect. Can you rebase your changes so we can merge it in?

[brettlangdon]

dammit... didn't meant for those other commits to get in there.

[conorbranagan]

No worries, it's all in master already anyway. Thanks for the pull! 🐶