Jkoppe supervisor and redhatinit fixes #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoppe
commented
Jun 22, 2012
jkoppe
commented
- Add options to make supervisorctl work
- Adjust redhat init script so its a bit more friendly to puppet's service type AND during interactive use by an admin
added 3 commits
June 22, 2012 13:57
…per http://supervisord.org/configuration.html since we want to use supervisorctl
…sor, 2) check_status with supervisorctl provides more useful messages and return codes, 3) grab_status uses check_status for return codes, 4) stop/start functions use grab_status before the supervisor test (before we only did grab_status checks inside the non-supervisorctl case)
ghost
assigned 
| @@ -13,20 +19,24 @@ pidfile = /var/run/datadog-supervisord.pid | |||
| logfile_backups = 10 | |||
|
|
|||
| [program:collector] | |||
| command=env LANG=POSIX /usr/bin/python /usr/share/datadog/agent/agent.py foreground --use-local-forwarder | |||
There was a problem hiding this comment.
We need to keep that LANG=POSIX set in the environment, otherwise it'll break in some non-US locales (e.g. Norway).
It's not needed for the forwarder though.
There was a problem hiding this comment.
oops, i meant to put that in the supervisor child subprocess environment field per http://supervisord.org/subprocess.html#subprocess-environment.
alq666
added a commit
that referenced
this pull request
Jun 22, 2012
…ixes Jkoppe supervisor and redhatinit fixes
olivielpeau
added a commit
that referenced
this pull request
Mar 23, 2016
* [FEATURE] Allow configuration of StatsD host. See [#85][] * [IMPROVEMENT] Re-throw IOException caught at the instance-level to handle them properly. See [#83][] [#83]: DataDog/jmxfetch#83 [#85]: DataDog/jmxfetch#85
olivielpeau
added a commit
that referenced
this pull request
Mar 23, 2016
**Changes** * [FEATURE] Allow configuration of StatsD host. See [#85][] * [IMPROVEMENT] Re-throw IOException caught at the instance-level to handle them properly. See [#83][] [#83]: DataDog/jmxfetch#83 [#85]: DataDog/jmxfetch#85
olivielpeau
added a commit
that referenced
this pull request
Mar 30, 2016
**Changes** * [FEATURE] Allow configuration of StatsD host. See [#85][] * [IMPROVEMENT] Re-throw IOException caught at the instance-level to handle them properly. See [#83][] [#83]: DataDog/jmxfetch#83 [#85]: DataDog/jmxfetch#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.