Snmp checks #983
Merged
Snmp checks #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 29, 2014 09:58
Also fixes bug for Counter metrics on several interfaces
Setting up environment for Travis.ci and basic test
Necessary to fix travis build (Cassandra version)
assertGreater not available on 2.6
Also fix a bug detected by a test
Also make it more clear that we add the name of the SNMP_device to the tags
Dynamically loaded class comparison doesn't work Accessing python's hidden attributes is freaking ugly but the clean way (ASN1 isSameTypeWith) doesn't work because CounterBasedGauge64 (a gauge) match with both ZeroBasedCounter64 and Counter64 ( counters ), given that these classes are just passthrough see sources at http://nullege.com/codes/show/[email protected]@[email protected]
Also don't convert to an int until it's sure
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #924