Fix template literals with numbers #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uurien
commented
Aug 7, 2024
| @@ -4,36 +4,37 @@ | |||
| **/ | |||
| /* eslint-disable no-template-curly-in-string */ | |||
| /* eslint-disable no-multi-str */ | |||
| const { rewriteAndExpectNoTransformation, rewriteAndExpect } = require('./util') | |||
| const { rewriteAst, rewriteAndExpectNoTransformation, rewriteAndExpect } = require('./util') | |||
There was a problem hiding this comment.
Most of the changes in this file are only tabs, I'll add comments in changed points
uurien
commented
Aug 7, 2024
| const js = 'const result = `Hello World!${a}`;' | ||
| rewriteAndExpect(js, '{\nconst result = _ddiast.plusOperator("Hello World!" + a, "Hello World!", a);\n}') | ||
| }) | ||
| it('Only vars', () => { |
uurien
commented
Aug 7, 2024
Comment on lines
+165
to
+166
| __datadog_test_1 = (__datadog_test_0 = _ddiast.plusOperator(\'bye \' + d, \'bye \', d), _ddiast.plusOperator(\ | ||
| __datadog_test_0 + "", __datadog_test_0, "")), _ddiast.plusOperator(\'how are u \' + __datadog_test_1, \'how are u \', \ |
There was a problem hiding this comment.
Small change in these lines, but nothing important, only the order from "" + __datadog_test_0 to __datadog_test_0 + ""
uurien
commented
Aug 7, 2024
| }) | ||
| }) | ||
|
|
||
| describe('Execution tests', () => { |
There was a problem hiding this comment.
All the tests in this describe are new
simon-id
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes some corner cases when template literals are used with numbers
Motivation
Fix the bugs
Additional Notes
Describe how to test your changes
Checklist