-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Visibility] Initial internal consts and utilities #2736
[CI Visibility] Initial internal consts and utilities #2736
Conversation
949de79
to
c4340ef
Compare
BenchmarksBenchmark execution time: 2024-07-08 09:54:59 Comparing candidate commit 1aba968 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 0 unstable metrics. scenario:BenchmarkHttpServeTrace-24
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
You forgot to review all our .github workflows to search for internal/
and add internal/civisibility
too to some of the go test commands we built-in there (we can't do go test ./... due to some contribs which require more or are incompatible between them)
615ef86
to
ccc1a39
Compare
As talked offline, civisibility tests are running without any workflow modification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This test depends on a real file of the repo, so if there are any unrelated changes to that file the test could fail. Most of the functions this test "tests" are already covered by other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: liashenko <[email protected]>
Co-authored-by: Tony Redondo <[email protected]> Co-authored-by: Manuel Palenzuela Merino <[email protected]> Co-authored-by: Dario Castañé <[email protected]>
What does this PR do?
This PR introduces the CI Visibility product in the repository with the following initial code:
Coverage is in the 94.2%
Motivation
We are working on adding Go as a supported language on the CI Visibility product.
This is the first PR of an stacked series.
More info is available in the guild slack channel.
Stacked PRs
Reviewer's Checklist
Unsure? Have a question? Request a review!