[CI Visibility] Add support for CI Visibility mode in ddtrace

ddtrace/tracer/civisibility_payload_test.go

@@ -18,10 +18,9 @@ import (
 )
 
 func newCiVisibilityEventsList(n int) []*ciVisibilityEvent {
-	itoa := map[int]string{0: "0", 1: "1", 2: "2", 3: "3", 4: "4", 5: "5"}
 	list := make([]*ciVisibilityEvent, n)
 	for i := 0; i < n; i++ {
-		s := newBasicSpan("span.list." + itoa[i%5+1])
+		s := newBasicSpan("span.list." + strconv.Itoa(i%5+1))
 		s.Start = fixedTime
 		list[i] = getCiVisibilityEvent(s)
 	}

ddtrace/tracer/civisibility_transport_test.go

@@ -21,7 +21,7 @@ import (
 
 func TestCiVisibilityTransport(t *testing.T) {
 	t.Run("agentless", func(t *testing.T) { runTransportTest(t, true) })
-	t.Run("agentbased", func(t *testing.T) { runTransportTest(t, true) })
+	t.Run("agentbased", func(t *testing.T) { runTransportTest(t, false) })
 }
 
 func runTransportTest(t *testing.T, agentless bool) {

ddtrace/tracer/civisibility_writer.go

@@ -30,7 +30,7 @@ var _ traceWriter = (*ciVisibilityTraceWriter)(nil)
 // to the Datadog backend. It manages the payload size and flushes the data when necessary.
 type ciVisibilityTraceWriter struct {
 	config  *config              // Configuration for the tracer.
-	payload *ciVisibilityPayload // Encodes and buffers traces in msgpack format.
+	payload *ciVisibilityPayload // Encodes and buffers events in msgpack format.
 	climit  chan struct{}        // Limits the number of concurrent outgoing connections.
 	wg      sync.WaitGroup       // Waits for all uploads to finish.
 }
@@ -104,16 +104,16 @@ func (w *ciVisibilityTraceWriter) flush() {
 		var err error
 		for attempt := 0; attempt <= w.config.sendRetries; attempt++ {
 			size, count = p.size(), p.itemCount()
-			log.Debug("Sending payload: size: %d traces: %d\n", size, count)
+			log.Debug("Sending payload: size: %d events: %d\n", size, count)
 			_, err = w.config.transport.send(p.payload)
 			if err == nil {
-				log.Debug("sent traces after %d attempts", attempt+1)
+				log.Debug("sent events after %d attempts", attempt+1)
 				return
 			}
-			log.Error("failure sending traces (attempt %d), will retry: %v", attempt+1, err)
+			log.Error("failure sending events (attempt %d), will retry: %v", attempt+1, err)
 			p.reset()
 			time.Sleep(time.Millisecond)
 		}
-		log.Error("lost %d traces: %v", count, err)
+		log.Error("lost %d events: %v", count, err)
 	}(oldp)
 }

ddtrace/tracer/civisibility_writer_test.go

@@ -8,12 +8,12 @@ package tracer
 import (
 	"errors"
 	"fmt"
-	"github.com/tinylib/msgp/msgp"
 	"io"
 	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/tinylib/msgp/msgp"
 )
 
 func TestCIVisibilityImplementsTraceWriter(t *testing.T) {