Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] tools: fix fixmodules script #3090

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jan 15, 2025

What does this PR do?

The tools/fixmodules script is used to fix the modules in the repository recursively, adding replace directives for imports of other modules in the same repository + using the same go version as the root module.

It had a bug where it was injecting some unnecessary replace since to the logic of inspecting go source files and checking import statement was broken.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 15, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 15, 2025

Datadog Report

Branch report: rarguelloF/fix-fixmodules-script
Commit report: 8299646
Test service: dd-trace-go

✅ 0 Failed, 4084 Passed, 64 Skipped, 2m 44.36s Total Time

@rarguelloF rarguelloF marked this pull request as ready for review January 16, 2025 11:01
@rarguelloF rarguelloF requested review from a team as code owners January 16, 2025 11:01
@darccio darccio merged commit d8fe1d5 into v2-dev Jan 17, 2025
175 of 178 checks passed
@darccio darccio deleted the rarguelloF/fix-fixmodules-script branch January 17, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants