Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/IBM/sarama.v1: stop using mockbroker for tests #3104

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jan 20, 2025

What does this PR do?

Change tests of IBM/sarama to use a real kafka broker instead of using sarama.NewMockBroker.

Motivation

The behavior of the mock broker has changed in future versions of IBM/sarama, which makes our v2 smoke tests fail. Instead of trying to hunt what changed and how to fix our tests with the new mock broker behavior, its better and more reliable to test things with an actual Kafka instance (which is how we test the rest of our Kafka integrations).

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@rarguelloF rarguelloF requested review from a team as code owners January 20, 2025 14:41
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 20, 2025
@rarguelloF rarguelloF force-pushed the rarguelloF/integration-tests-sarama branch from bc8b350 to a33040c Compare January 20, 2025 14:42
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 20, 2025

Datadog Report

Branch report: rarguelloF/integration-tests-sarama
Commit report: 8676eeb
Test service: dd-trace-go

✅ 0 Failed, 3011 Passed, 25 Skipped, 2m 19.26s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Benchmarks

Benchmark execution time: 2025-01-20 16:46:17

Comparing candidate commit f7d2f03 in PR branch rarguelloF/integration-tests-sarama with baseline commit 2e3193f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@rarguelloF rarguelloF enabled auto-merge (squash) January 20, 2025 16:21
@rarguelloF rarguelloF merged commit e394045 into main Jan 20, 2025
172 of 173 checks passed
@rarguelloF rarguelloF deleted the rarguelloF/integration-tests-sarama branch January 20, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants