contrib/IBM/sarama.v1: stop using mockbroker for tests #3104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change tests of
IBM/sarama
to use a real kafka broker instead of usingsarama.NewMockBroker
.Motivation
The behavior of the mock broker has changed in future versions of IBM/sarama, which makes our v2 smoke tests fail. Instead of trying to hunt what changed and how to fix our tests with the new mock broker behavior, its better and more reliable to test things with an actual Kafka instance (which is how we test the rest of our Kafka integrations).
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!