Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Extensions Macro Benchmarks #3106

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Jan 20, 2025

What does this PR do?

  • Add Macro Benchmarks for Service Extensions.
    This PR from Benchmarking Platform merge the changes that adds scenarios for Service Extensions into the go/go-prof-app branch.

  • It also updates the base image name to the new one that includes Envoy.

Motivation

QA feedbacks on each main commits.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@e-n-0 e-n-0 marked this pull request as ready for review January 20, 2025 15:27
@e-n-0 e-n-0 requested review from a team as code owners January 20, 2025 15:27
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 20, 2025

Datadog Report

Branch report: flavien/envoy/merge-brenchmarks
Commit report: 514a960
Test service: dd-trace-go

✅ 0 Failed, 5201 Passed, 72 Skipped, 2m 19.87s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Benchmarks

Benchmark execution time: 2025-01-22 13:17:13

Comparing candidate commit bd304cc in PR branch flavien/envoy/merge-brenchmarks with baseline commit 45ce7b6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

.gitlab/macrobenchmarks.yml Show resolved Hide resolved
.gitlab/macrobenchmarks.yml Show resolved Hide resolved
@darccio darccio requested a review from a team January 21, 2025 09:48
@e-n-0 e-n-0 force-pushed the flavien/envoy/merge-brenchmarks branch from 0436ca9 to bd304cc Compare January 22, 2025 12:50
@eliottness eliottness merged commit 241a6f1 into main Jan 22, 2025
174 checks passed
@eliottness eliottness deleted the flavien/envoy/merge-brenchmarks branch January 22, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants