Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage API v2 #3109

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Baggage API v2 #3109

merged 1 commit into from
Jan 23, 2025

Conversation

rachelyangdog
Copy link
Contributor

What does this PR do?

porting baggage api to v2

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

Co-authored-by: Mikayla Toffler <[email protected]>
@rachelyangdog rachelyangdog requested review from a team as code owners January 21, 2025 18:50
@rachelyangdog rachelyangdog changed the base branch from main to v2-dev January 21, 2025 18:54
@pr-commenter
Copy link

pr-commenter bot commented Jan 21, 2025

Benchmarks

Benchmark execution time: 2025-01-21 19:29:04

Comparing candidate commit e86d745 in PR branch rachel.yang/baggage-api-v2 with baseline commit 519c69e in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

@mtoffl01 mtoffl01 merged commit 7d516f3 into v2-dev Jan 23, 2025
2 checks passed
@mtoffl01 mtoffl01 deleted the rachel.yang/baggage-api-v2 branch January 23, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants