Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peer tags configuration #3132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ichinaski
Copy link
Contributor

@ichinaski ichinaski commented Jan 31, 2025

What does this PR do?

Upon reading the info response from the Agent, we must store the peer_tags internally, which are used for Client-Stats computation.

Motivation

Client-Side Stats require peer tags aggregation. Agent e2e tests revealed that these were missing.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@ichinaski ichinaski requested a review from a team as a code owner January 31, 2025 11:53
Upon reading the info response from the Agent, we must store the
peer_tags internally, which are used for Client-Stats computation.
@ichinaski ichinaski force-pushed the ichinaski/fix-peer-tags-config branch from efabc19 to f31e3aa Compare January 31, 2025 11:55
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: ichinaski/fix-peer-tags-config
Commit report: 226fdbc
Test service: dd-trace-go

✅ 0 Failed, 5216 Passed, 72 Skipped, 2m 31.71s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025

Benchmarks

Benchmark execution time: 2025-01-31 12:22:07

Comparing candidate commit f31e3aa in PR branch ichinaski/fix-peer-tags-config with baseline commit ddfe2d4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants