Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) internal/civisibility: add Known Tests feature and refactor EFD logic #3139

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR refactors the Early Flake Detection feature to stop depending on the test.is_new tag and introduces the Known Tests feature.

Motivation

RFC: https://docs.google.com/document/d/1mPMM7Uye2jHUMx5ADTMSRt_Rff98klRLj5OpTruszzQ/edit?tab=t.0

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo requested review from a team as code owners February 3, 2025 12:36
@tonyredondo tonyredondo requested a review from liashenko February 3, 2025 12:36
@tonyredondo tonyredondo changed the title Tony/civisibility known tests (feat) internal/civisibility: add Known Tests feature and refactor EFD logic Feb 3, 2025
@tonyredondo tonyredondo force-pushed the tony/civisibility-known-tests branch from a5d6d39 to f2546cc Compare February 3, 2025 12:37
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 3, 2025

Datadog Report

Branch report: tony/civisibility-known-tests
Commit report: 76834db
Test service: dd-trace-go

✅ 0 Failed, 5222 Passed, 72 Skipped, 2m 11.81s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025

Benchmarks

Benchmark execution time: 2025-02-03 21:58:46

Comparing candidate commit 1a9f6c2 in PR branch tony/civisibility-known-tests with baseline commit dbfb8f2 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics.

scenario:BenchmarkPartialFlushing/Enabled-24

  • 🟥 avgHeapInUse(Mb) [+1.769MB; +6.505MB] or [+2.579%; +9.484%]

@tonyredondo tonyredondo force-pushed the tony/civisibility-known-tests branch from f2546cc to 1a9f6c2 Compare February 3, 2025 21:32
@tonyredondo tonyredondo merged commit 998add0 into main Feb 3, 2025
176 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-known-tests branch February 3, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants