Service naming: split by jee deployment #8064

amarziali · 2024-12-06T14:51:40Z

What Does This Do

This PR tries to address in a more complete way the need to use different service naming depending on the deployed application which is generating spans.
The traditional approach is based on splitting by servlet.context which works only in a servlet context.

This approach is based on fingerprinting the classloader that's attached to the current thread (context classloader) when the span is created.
In fact, application servers have particular classloaders used to isolate the code of each deployment unit.
Depending to each application server, the classloader contains information about the deployment name and this information can be used at this point to set the service name.

This will work also outside a servlet context (i.e. ejb, scheduled calls, etc..)

The feature is experimental and works for tomcat, jboss and websphere (liberty). In order to activate please set the sysprop -Ddd.trace.experimental.jee.split-by-deployment=true

This will disable the usual split-by-servlet-context mechanism meaning that possibly the service name can be different from the one previously used.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

...st-5/src/main/java/datadog/trace/instrumentation/servlet5/JakartaServletInstrumentation.java

pr-commenter · 2024-12-06T15:25:16Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/ee-classloader
git_commit_date	1734005386	1734008088
git_commit_sha	`9918d21`	`933c7fa`
release_version	1.44.0-SNAPSHOT~9918d219cf	1.44.0-SNAPSHOT~933c7fa836

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734010594	1734010594
ci_job_id	736518872	736518872
ci_pipeline_id	50944615	50944615
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~933c7fa836, baseline=1.44.0-SNAPSHOT~9918d219cf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094087
Total [baseline] (10.412 s) : 0, 10411602
Agent [candidate] (1.096 s) : 0, 1095582
Total [candidate] (10.399 s) : 0, 10399135
section appsec
Agent [baseline] (1.233 s) : 0, 1233469
Total [baseline] (10.735 s) : 0, 10734866
Agent [candidate] (1.227 s) : 0, 1227024
Total [candidate] (10.717 s) : 0, 10717208
section iast
Agent [baseline] (1.229 s) : 0, 1229204
Total [baseline] (11.017 s) : 0, 11017264
Agent [candidate] (1.219 s) : 0, 1219265
Total [candidate] (10.995 s) : 0, 10994529
section profiling
Agent [baseline] (1.326 s) : 0, 1326349
Total [baseline] (10.817 s) : 0, 10816680
Agent [candidate] (1.322 s) : 0, 1322375
Total [candidate] (10.77 s) : 0, 10770122

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	appsec	1.233 s	139.382 ms (12.7%)
Agent	iast	1.229 s	135.117 ms (12.3%)
Agent	profiling	1.326 s	232.262 ms (21.2%)
Total	tracing	10.412 s	-
Total	appsec	10.735 s	323.263 ms (3.1%)
Total	iast	11.017 s	605.662 ms (5.8%)
Total	profiling	10.817 s	405.078 ms (3.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	appsec	1.227 s	131.442 ms (12.0%)
Agent	iast	1.219 s	123.683 ms (11.3%)
Agent	profiling	1.322 s	226.793 ms (20.7%)
Total	tracing	10.399 s	-
Total	appsec	10.717 s	318.073 ms (3.1%)
Total	iast	10.995 s	595.394 ms (5.7%)
Total	profiling	10.77 s	370.987 ms (3.6%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~933c7fa836, baseline=1.44.0-SNAPSHOT~9918d219cf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.974 ms) : 0, 695974
BytebuddyAgent [candidate] (696.538 ms) : 0, 696538
GlobalTracer [baseline] (318.218 ms) : 0, 318218
GlobalTracer [candidate] (318.409 ms) : 0, 318409
AppSec [baseline] (54.732 ms) : 0, 54732
AppSec [candidate] (54.749 ms) : 0, 54749
Remote Config [baseline] (678.43 µs) : 0, 678
Remote Config [candidate] (674.666 µs) : 0, 675
Telemetry [baseline] (10.725 ms) : 0, 10725
Telemetry [candidate] (11.416 ms) : 0, 11416
section appsec
BytebuddyAgent [baseline] (717.198 ms) : 0, 717198
BytebuddyAgent [candidate] (713.054 ms) : 0, 713054
GlobalTracer [baseline] (316.922 ms) : 0, 316922
GlobalTracer [candidate] (314.915 ms) : 0, 314915
AppSec [baseline] (166.8 ms) : 0, 166800
AppSec [candidate] (167.4 ms) : 0, 167400
Remote Config [baseline] (656.395 µs) : 0, 656
Remote Config [candidate] (643.639 µs) : 0, 644
Telemetry [baseline] (8.572 ms) : 0, 8572
Telemetry [candidate] (7.809 ms) : 0, 7809
IAST [baseline] (19.043 ms) : 0, 19043
IAST [candidate] (18.911 ms) : 0, 18911
section iast
BytebuddyAgent [baseline] (819.408 ms) : 0, 819408
BytebuddyAgent [candidate] (812.352 ms) : 0, 812352
GlobalTracer [baseline] (307.646 ms) : 0, 307646
GlobalTracer [candidate] (306.029 ms) : 0, 306029
AppSec [baseline] (58.507 ms) : 0, 58507
AppSec [candidate] (57.975 ms) : 0, 57975
Remote Config [baseline] (642.561 µs) : 0, 643
Remote Config [candidate] (630.097 µs) : 0, 630
Telemetry [baseline] (7.635 ms) : 0, 7635
Telemetry [candidate] (7.47 ms) : 0, 7470
IAST [baseline] (21.366 ms) : 0, 21366
IAST [candidate] (21.024 ms) : 0, 21024
section profiling
ProfilingAgent [baseline] (94.533 ms) : 0, 94533
ProfilingAgent [candidate] (94.262 ms) : 0, 94262
BytebuddyAgent [baseline] (694.518 ms) : 0, 694518
BytebuddyAgent [candidate] (690.647 ms) : 0, 690647
GlobalTracer [baseline] (435.47 ms) : 0, 435470
GlobalTracer [candidate] (436.0 ms) : 0, 436000
AppSec [baseline] (53.974 ms) : 0, 53974
AppSec [candidate] (53.858 ms) : 0, 53858
Remote Config [baseline] (683.489 µs) : 0, 683
Remote Config [candidate] (684.537 µs) : 0, 685
Telemetry [baseline] (7.792 ms) : 0, 7792
Telemetry [candidate] (7.74 ms) : 0, 7740
Profiling [baseline] (94.557 ms) : 0, 94557
Profiling [candidate] (94.287 ms) : 0, 94287

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~933c7fa836, baseline=1.44.0-SNAPSHOT~9918d219cf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1095965
Total [baseline] (8.681 s) : 0, 8681248
Agent [candidate] (1.096 s) : 0, 1096060
Total [candidate] (8.633 s) : 0, 8633469
section iast
Agent [baseline] (1.22 s) : 0, 1219757
Total [baseline] (9.224 s) : 0, 9223865
Agent [candidate] (1.224 s) : 0, 1224186
Total [candidate] (9.207 s) : 0, 9207468
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.231 s) : 0, 1231411
Total [baseline] (9.21 s) : 0, 9209539
Agent [candidate] (1.224 s) : 0, 1223524
Total [candidate] (9.143 s) : 0, 9142995
section iast_TELEMETRY_OFF
Agent [baseline] (1.219 s) : 0, 1218994
Total [baseline] (9.198 s) : 0, 9198018
Agent [candidate] (1.219 s) : 0, 1219147
Total [candidate] (9.175 s) : 0, 9175261

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	iast	1.22 s	123.792 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.231 s	135.446 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.219 s	123.029 ms (11.2%)
Total	tracing	8.681 s	-
Total	iast	9.224 s	542.617 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.21 s	528.29 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.198 s	516.769 ms (6.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	iast	1.224 s	128.127 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.224 s	127.464 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.219 s	123.087 ms (11.2%)
Total	tracing	8.633 s	-
Total	iast	9.207 s	573.999 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.143 s	509.526 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.175 s	541.792 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~933c7fa836, baseline=1.44.0-SNAPSHOT~9918d219cf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.494 ms) : 0, 697494
BytebuddyAgent [candidate] (697.307 ms) : 0, 697307
GlobalTracer [baseline] (318.848 ms) : 0, 318848
GlobalTracer [candidate] (319.709 ms) : 0, 319709
AppSec [baseline] (55.08 ms) : 0, 55080
AppSec [candidate] (55.205 ms) : 0, 55205
Remote Config [baseline] (689.293 µs) : 0, 689
Remote Config [candidate] (682.178 µs) : 0, 682
Telemetry [baseline] (10.06 ms) : 0, 10060
Telemetry [candidate] (9.352 ms) : 0, 9352
section iast
BytebuddyAgent [baseline] (812.727 ms) : 0, 812727
BytebuddyAgent [candidate] (815.956 ms) : 0, 815956
GlobalTracer [baseline] (305.766 ms) : 0, 305766
GlobalTracer [candidate] (306.668 ms) : 0, 306668
AppSec [baseline] (57.219 ms) : 0, 57219
AppSec [candidate] (57.827 ms) : 0, 57827
Remote Config [baseline] (640.816 µs) : 0, 641
Remote Config [candidate] (628.728 µs) : 0, 629
Telemetry [baseline] (7.504 ms) : 0, 7504
Telemetry [candidate] (7.438 ms) : 0, 7438
IAST [baseline] (22.049 ms) : 0, 22049
IAST [candidate] (21.884 ms) : 0, 21884
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (820.575 ms) : 0, 820575
BytebuddyAgent [candidate] (814.496 ms) : 0, 814496
GlobalTracer [baseline] (308.68 ms) : 0, 308680
GlobalTracer [candidate] (307.272 ms) : 0, 307272
AppSec [baseline] (58.709 ms) : 0, 58709
AppSec [candidate] (56.826 ms) : 0, 56826
Remote Config [baseline] (634.145 µs) : 0, 634
Remote Config [candidate] (703.366 µs) : 0, 703
Telemetry [baseline] (7.609 ms) : 0, 7609
Telemetry [candidate] (7.543 ms) : 0, 7543
IAST [baseline] (21.425 ms) : 0, 21425
IAST [candidate] (22.882 ms) : 0, 22882
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (810.953 ms) : 0, 810953
BytebuddyAgent [candidate] (811.536 ms) : 0, 811536
GlobalTracer [baseline] (306.472 ms) : 0, 306472
GlobalTracer [candidate] (307.245 ms) : 0, 307245
AppSec [baseline] (57.965 ms) : 0, 57965
AppSec [candidate] (57.263 ms) : 0, 57263
Remote Config [baseline] (645.185 µs) : 0, 645
Remote Config [candidate] (639.406 µs) : 0, 639
Telemetry [baseline] (7.505 ms) : 0, 7505
Telemetry [candidate] (7.343 ms) : 0, 7343
IAST [baseline] (21.691 ms) : 0, 21691
IAST [candidate] (21.29 ms) : 0, 21290

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-12T13:04:35	2024-12-12T13:11:32
git_branch	master	andrea.marziali/ee-classloader
git_commit_date	1734005386	1734008088
git_commit_sha	`9918d21`	`933c7fa`
release_version	1.44.0-SNAPSHOT~9918d219cf	1.44.0-SNAPSHOT~933c7fa836
start_time	2024-12-12T13:04:22	2024-12-12T13:11:18

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734009442	1734009442
ci_job_id	736518873	736518873
ci_pipeline_id	50944615	50944615
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~933c7fa836, baseline=1.44.0-SNAPSHOT~9918d219cf
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.337 µs) : 347, 387
.   : milestone, 367,
iast (487.142 µs) : 466, 509
.   : milestone, 487,
iast_FULL (645.513 µs) : 624, 667
.   : milestone, 646,
iast_GLOBAL (521.354 µs) : 500, 543
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (481.083 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (440.458 µs) : 420, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (481.502 µs) : 459, 504
.   : milestone, 482,
tracing (444.979 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (370.453 µs) : 351, 390
.   : milestone, 370,
iast (498.932 µs) : 477, 521
.   : milestone, 499,
iast_FULL (640.597 µs) : 619, 662
.   : milestone, 641,
iast_GLOBAL (511.851 µs) : 490, 533
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (482.977 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (447.009 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (469.512 µs) : 448, 491
.   : milestone, 470,
tracing (438.675 µs) : 418, 459
.   : milestone, 439,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.337 µs [347.387 µs, 387.286 µs]	-
iast	487.142 µs [465.656 µs, 508.628 µs]	119.805 µs (32.6%)
iast_FULL	645.513 µs [624.126 µs, 666.901 µs]	278.177 µs (75.7%)
iast_GLOBAL	521.354 µs [499.662 µs, 543.046 µs]	154.017 µs (41.9%)
iast_HARDCODED_SECRET_DISABLED	481.083 µs [459.913 µs, 502.253 µs]	113.746 µs (31.0%)
iast_INACTIVE	440.458 µs [419.863 µs, 461.053 µs]	73.121 µs (19.9%)
iast_TELEMETRY_OFF	481.502 µs [458.552 µs, 504.451 µs]	114.165 µs (31.1%)
tracing	444.979 µs [424.001 µs, 465.957 µs]	77.642 µs (21.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.453 µs [350.623 µs, 390.282 µs]	-
iast	498.932 µs [477.131 µs, 520.734 µs]	128.48 µs (34.7%)
iast_FULL	640.597 µs [619.038 µs, 662.157 µs]	270.144 µs (72.9%)
iast_GLOBAL	511.851 µs [490.489 µs, 533.213 µs]	141.399 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED	482.977 µs [461.926 µs, 504.029 µs]	112.525 µs (30.4%)
iast_INACTIVE	447.009 µs [425.753 µs, 468.266 µs]	76.557 µs (20.7%)
iast_TELEMETRY_OFF	469.512 µs [448.181 µs, 490.843 µs]	99.059 µs (26.7%)
tracing	438.675 µs [418.182 µs, 459.168 µs]	68.222 µs (18.4%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~933c7fa836, baseline=1.44.0-SNAPSHOT~9918d219cf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.738 ms) : 1713, 1764
.   : milestone, 1738,
appsec_no_iast (1.756 ms) : 1732, 1780
.   : milestone, 1756,
iast (1.485 ms) : 1462, 1507
.   : milestone, 1485,
profiling (1.505 ms) : 1482, 1529
.   : milestone, 1505,
tracing (1.491 ms) : 1467, 1515
.   : milestone, 1491,
section candidate
no_agent (1.345 ms) : 1324, 1365
.   : milestone, 1345,
appsec (1.768 ms) : 1745, 1792
.   : milestone, 1768,
appsec_no_iast (1.739 ms) : 1713, 1764
.   : milestone, 1739,
iast (1.479 ms) : 1457, 1502
.   : milestone, 1479,
profiling (1.522 ms) : 1499, 1546
.   : milestone, 1522,
tracing (1.474 ms) : 1449, 1499
.   : milestone, 1474,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.354 ms [1.335 ms, 1.373 ms]	-
appsec	1.738 ms [1.713 ms, 1.764 ms]	384.377 µs (28.4%)
appsec_no_iast	1.756 ms [1.732 ms, 1.78 ms]	401.784 µs (29.7%)
iast	1.485 ms [1.462 ms, 1.507 ms]	130.752 µs (9.7%)
profiling	1.505 ms [1.482 ms, 1.529 ms]	151.391 µs (11.2%)
tracing	1.491 ms [1.467 ms, 1.515 ms]	136.603 µs (10.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.345 ms [1.324 ms, 1.365 ms]	-
appsec	1.768 ms [1.745 ms, 1.792 ms]	423.713 µs (31.5%)
appsec_no_iast	1.739 ms [1.713 ms, 1.764 ms]	393.921 µs (29.3%)
iast	1.479 ms [1.457 ms, 1.502 ms]	134.583 µs (10.0%)
profiling	1.522 ms [1.499 ms, 1.546 ms]	177.572 µs (13.2%)
tracing	1.474 ms [1.449 ms, 1.499 ms]	129.717 µs (9.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/ee-classloader
git_commit_date	1734005386	1734008088
git_commit_sha	`9918d21`	`933c7fa`
release_version	1.44.0-SNAPSHOT~9918d219cf	1.44.0-SNAPSHOT~933c7fa836

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1734010126	1734010126
ci_job_id	736518874	736518874
ci_pipeline_id	50944615	50944615
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~933c7fa836, baseline=1.44.0-SNAPSHOT~9918d219cf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.337 ms) : 2296, 2379
.   : milestone, 2337,
iast (2.095 ms) : 2042, 2148
.   : milestone, 2095,
iast_GLOBAL (2.131 ms) : 2077, 2184
.   : milestone, 2131,
profiling (1.947 ms) : 1905, 1989
.   : milestone, 1947,
tracing (1.941 ms) : 1900, 1981
.   : milestone, 1941,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.349 ms) : 2307, 2390
.   : milestone, 2349,
iast (2.082 ms) : 2030, 2135
.   : milestone, 2082,
iast_GLOBAL (2.125 ms) : 2072, 2177
.   : milestone, 2125,
profiling (1.979 ms) : 1935, 2022
.   : milestone, 1979,
tracing (1.93 ms) : 1889, 1970
.   : milestone, 1930,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.337 ms [2.296 ms, 2.379 ms]	868.043 µs (59.1%)
iast	2.095 ms [2.042 ms, 2.148 ms]	625.943 µs (42.6%)
iast_GLOBAL	2.131 ms [2.077 ms, 2.184 ms]	661.185 µs (45.0%)
profiling	1.947 ms [1.905 ms, 1.989 ms]	477.753 µs (32.5%)
tracing	1.941 ms [1.9 ms, 1.981 ms]	471.286 µs (32.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.349 ms [2.307 ms, 2.39 ms]	877.842 µs (59.7%)
iast	2.082 ms [2.03 ms, 2.135 ms]	611.244 µs (41.6%)
iast_GLOBAL	2.125 ms [2.072 ms, 2.177 ms]	653.83 µs (44.5%)
profiling	1.979 ms [1.935 ms, 2.022 ms]	507.761 µs (34.5%)
tracing	1.93 ms [1.889 ms, 1.97 ms]	458.801 µs (31.2%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~933c7fa836, baseline=1.44.0-SNAPSHOT~9918d219cf
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.207 s) : 15207000, 15207000
.   : milestone, 15207000,
appsec (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
iast (18.932 s) : 18932000, 18932000
.   : milestone, 18932000,
iast_GLOBAL (17.928 s) : 17928000, 17928000
.   : milestone, 17928000,
profiling (15.097 s) : 15097000, 15097000
.   : milestone, 15097000,
tracing (15.017 s) : 15017000, 15017000
.   : milestone, 15017000,
section candidate
no_agent (15.552 s) : 15552000, 15552000
.   : milestone, 15552000,
appsec (14.586 s) : 14586000, 14586000
.   : milestone, 14586000,
iast (18.744 s) : 18744000, 18744000
.   : milestone, 18744000,
iast_GLOBAL (17.863 s) : 17863000, 17863000
.   : milestone, 17863000,
profiling (15.443 s) : 15443000, 15443000
.   : milestone, 15443000,
tracing (15.249 s) : 15249000, 15249000
.   : milestone, 15249000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.207 s [15.207 s, 15.207 s]	-
appsec	15.242 s [15.242 s, 15.242 s]	35.0 ms (0.2%)
iast	18.932 s [18.932 s, 18.932 s]	3.725 s (24.5%)
iast_GLOBAL	17.928 s [17.928 s, 17.928 s]	2.721 s (17.9%)
profiling	15.097 s [15.097 s, 15.097 s]	-110.0 ms (-0.7%)
tracing	15.017 s [15.017 s, 15.017 s]	-190.0 ms (-1.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.552 s [15.552 s, 15.552 s]	-
appsec	14.586 s [14.586 s, 14.586 s]	-966.0 ms (-6.2%)
iast	18.744 s [18.744 s, 18.744 s]	3.192 s (20.5%)
iast_GLOBAL	17.863 s [17.863 s, 17.863 s]	2.311 s (14.9%)
profiling	15.443 s [15.443 s, 15.443 s]	-109.0 ms (-0.7%)
tracing	15.249 s [15.249 s, 15.249 s]	-303.0 ms (-1.9%)

PerfectSlayer

I had a hard time with how the Gradle modules are set for the tomcat thing:

About :tomcat-classloading-9, is :tomcat-classloading a library?
Or is it a classloading specific module only supported for tomcat 9? (so I would expect to find it under :tomcat-9:classloading or similar.
And how is the testing working? The Gradle configuration of tomcat-classloading-9 requires to evaluation the tomcat-5.5 while the tomcat-5.5 requires the tomcat-classloading-9 as dependency 🤔

Overall it looks good! I am curious about the customer feedback 👍

...jboss-modules/src/main/java/datadog/trace/instrumentation/jbossmodules/ModuleNameHelper.java

...ation/liberty-20/src/main/java/datadog/trace/instrumentation/liberty20/BundleNameHelper.java

...st-5/src/main/java/datadog/trace/instrumentation/servlet5/JakartaServletInstrumentation.java

PerfectSlayer · 2024-12-12T09:50:20Z

dd-smoke-tests/wildfly/build.gradle

@@ -1,15 +1,19 @@
 ext {
  serverName = 'wildfly'
-  serverModule = 'servlet'
+  //serverModule = 'servlet'


I did it on purpose to have people understand how those artifacts are resolved

dd-smoke-tests/wildfly/build.gradle

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java

internal-api/src/main/java/datadog/trace/api/naming/ClassloaderServiceNames.java

...-modules/src/main/java/datadog/trace/instrumentation/jbossmodules/ModuleInstrumentation.java

amarziali · 2024-12-12T11:11:44Z

I had a hard time with how the Gradle modules are set for the tomcat thing:

About :tomcat-classloading-9, is :tomcat-classloading a library?
Or is it a classloading specific module only supported for tomcat 9? (so I would expect to find it under :tomcat-9:classloading or similar.

It's just a module for tomcat 9+. It should be on :tomcat:tomcat-9. we have lots of other modules dangling on the root. I agree that should be refactored in order to have everything under the tomcat umbrella. I can propose a separate PR for it (I really did not want to add more changeset to that one since it's already complex enough)

And how is the testing working? The Gradle configuration of tomcat-classloading-9 requires to evaluation the tomcat-5.5 while the tomcat-5.5 requires the tomcat-classloading-9 as dependency 🤔

Testing is done on tomcat-5.5 since the tests are there. However it's tested with the latestDep and latest10. It should be also tested with tomcat 9 but we do not test it either for other instrumentation. IMHO it's too old to have test for.

...y-20/src/main/java/datadog/trace/instrumentation/liberty20/LibertyServerInstrumentation.java

...in/java/datadog/trace/instrumentation/liberty20/ThreadContextClassloaderInstrumentation.java

...y-23/src/main/java/datadog/trace/instrumentation/liberty23/LibertyServerInstrumentation.java

internal-api/src/main/java/datadog/trace/api/naming/ClassloaderServiceNames.java

...ervlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/Servlet3Decorator.java

internal-api/src/main/java/datadog/trace/api/naming/ClassloaderServiceNames.java

mcculls

+1 with comments

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

amarziali added type: enhancement comp: core Tracer core tag: experimental Experimental changes labels Dec 6, 2024

amarziali requested review from a team as code owners December 6, 2024 14:51

amarziali requested a review from dougqh December 6, 2024 14:51

mcculls reviewed Dec 6, 2024

View reviewed changes

...st-5/src/main/java/datadog/trace/instrumentation/servlet5/JakartaServletInstrumentation.java Outdated Show resolved Hide resolved

amarziali force-pushed the andrea.marziali/ee-classloader branch 3 times, most recently from ef3e4b2 to eec3ea0 Compare December 9, 2024 15:34

amarziali requested a review from mcculls December 9, 2024 15:35

amarziali force-pushed the andrea.marziali/ee-classloader branch 2 times, most recently from 973d2be to cc0bfe9 Compare December 10, 2024 09:38

PerfectSlayer reviewed Dec 12, 2024

View reviewed changes

mcculls reviewed Dec 12, 2024

View reviewed changes

internal-api/src/main/java/datadog/trace/api/naming/ClassloaderServiceNames.java Outdated Show resolved Hide resolved

amarziali added 9 commits December 12, 2024 11:58

Service naming: split by jee deployment

cac1c30

Do not use invokedynamic

47a72fc

fix tests

fe24e62

collapse enter and local

e9c2536

Adjust service name for non legacy tracing

a0b2e0e

Add wildfly ejb test

12df126

limit max java verson to 11 for wildfly 15

5765d30

renaming

4b43be2

refactor according to the review

c2cb1c4

amarziali force-pushed the andrea.marziali/ee-classloader branch from ce40405 to c2cb1c4 Compare December 12, 2024 10:58

remove helper

a40b4dc

mcculls reviewed Dec 12, 2024

View reviewed changes

...-modules/src/main/java/datadog/trace/instrumentation/jbossmodules/ModuleInstrumentation.java Outdated Show resolved Hide resolved

avoid casting

1bdfabf

mcculls reviewed Dec 12, 2024

View reviewed changes

...y-20/src/main/java/datadog/trace/instrumentation/liberty20/LibertyServerInstrumentation.java Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

...in/java/datadog/trace/instrumentation/liberty20/ThreadContextClassloaderInstrumentation.java Outdated Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

...y-23/src/main/java/datadog/trace/instrumentation/liberty23/LibertyServerInstrumentation.java Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

internal-api/src/main/java/datadog/trace/api/naming/ClassloaderServiceNames.java Outdated Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

internal-api/src/main/java/datadog/trace/api/naming/ClassloaderServiceNames.java Outdated Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

...ervlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/Servlet3Decorator.java Outdated Show resolved Hide resolved

mcculls reviewed Dec 12, 2024

View reviewed changes

internal-api/src/main/java/datadog/trace/api/naming/ClassloaderServiceNames.java Outdated Show resolved Hide resolved

mcculls approved these changes Dec 12, 2024

View reviewed changes

review

20d93e3

amarziali enabled auto-merge (squash) December 12, 2024 11:54

amarziali added 2 commits December 12, 2024 13:29

revert lastindexof

0559bdb

enforce checks

933c7fa

amarziali merged commit 5dd63de into master Dec 12, 2024
150 checks passed

amarziali deleted the andrea.marziali/ee-classloader branch December 12, 2024 13:46

github-actions bot added this to the 1.44.0 milestone Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Service naming: split by jee deployment #8064

Service naming: split by jee deployment #8064

amarziali commented Dec 6, 2024

pr-commenter bot commented Dec 6, 2024 •

edited

Loading

PerfectSlayer left a comment

PerfectSlayer Dec 12, 2024

amarziali Dec 12, 2024

amarziali commented Dec 12, 2024

mcculls left a comment

Service naming: split by jee deployment #8064

Service naming: split by jee deployment #8064

Conversation

amarziali commented Dec 6, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Dec 6, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

PerfectSlayer left a comment

Choose a reason for hiding this comment

PerfectSlayer Dec 12, 2024

Choose a reason for hiding this comment

amarziali Dec 12, 2024

Choose a reason for hiding this comment

amarziali commented Dec 12, 2024

mcculls left a comment

Choose a reason for hiding this comment

pr-commenter bot commented Dec 6, 2024 •

edited

Loading