-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement impacted tests detection #8188
Merged
nikita-tkachenko-datadog
merged 16 commits into
master
from
nikita-tkachenko/impacted-tests
Jan 22, 2025
Merged
Implement impacted tests detection #8188
nikita-tkachenko-datadog
merged 16 commits into
master
from
nikita-tkachenko/impacted-tests
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
tag: no release notes
Changes to exclude from release notes
type: refactoring
comp: ci visibility
Continuous Integration Visibility
labels
Jan 13, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~9b370b2dd7, baseline=1.46.0-SNAPSHOT~523df01c66
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050908
Total [baseline] (10.436 s) : 0, 10436439
Agent [candidate] (1.056 s) : 0, 1056033
Total [candidate] (10.438 s) : 0, 10437507
section appsec
Agent [baseline] (1.19 s) : 0, 1189718
Total [baseline] (10.752 s) : 0, 10752193
Agent [candidate] (1.193 s) : 0, 1192607
Total [candidate] (10.686 s) : 0, 10685910
section iast
Agent [baseline] (1.183 s) : 0, 1183328
Total [baseline] (10.951 s) : 0, 10950940
Agent [candidate] (1.182 s) : 0, 1182325
Total [candidate] (10.998 s) : 0, 10998129
section profiling
Agent [baseline] (1.256 s) : 0, 1256118
Total [baseline] (10.856 s) : 0, 10855851
Agent [candidate] (1.261 s) : 0, 1260653
Total [candidate] (10.785 s) : 0, 10785254
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~9b370b2dd7, baseline=1.46.0-SNAPSHOT~523df01c66
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.966 ms) : 0, 711966
BytebuddyAgent [candidate] (714.835 ms) : 0, 714835
GlobalTracer [baseline] (254.477 ms) : 0, 254477
GlobalTracer [candidate] (255.388 ms) : 0, 255388
AppSec [baseline] (55.381 ms) : 0, 55381
AppSec [candidate] (56.443 ms) : 0, 56443
Remote Config [baseline] (726.826 µs) : 0, 727
Remote Config [candidate] (731.648 µs) : 0, 732
Telemetry [baseline] (13.408 ms) : 0, 13408
Telemetry [candidate] (13.669 ms) : 0, 13669
section appsec
BytebuddyAgent [baseline] (732.333 ms) : 0, 732333
BytebuddyAgent [candidate] (733.578 ms) : 0, 733578
GlobalTracer [baseline] (252.535 ms) : 0, 252535
GlobalTracer [candidate] (254.046 ms) : 0, 254046
AppSec [baseline] (171.365 ms) : 0, 171365
AppSec [candidate] (171.01 ms) : 0, 171010
Remote Config [baseline] (669.746 µs) : 0, 670
Remote Config [candidate] (667.625 µs) : 0, 668
Telemetry [baseline] (8.161 ms) : 0, 8161
Telemetry [candidate] (8.58 ms) : 0, 8580
IAST [baseline] (19.336 ms) : 0, 19336
IAST [candidate] (19.427 ms) : 0, 19427
section iast
BytebuddyAgent [baseline] (832.067 ms) : 0, 832067
BytebuddyAgent [candidate] (831.134 ms) : 0, 831134
GlobalTracer [baseline] (246.926 ms) : 0, 246926
GlobalTracer [candidate] (246.917 ms) : 0, 246917
AppSec [baseline] (58.171 ms) : 0, 58171
AppSec [candidate] (58.165 ms) : 0, 58165
Remote Config [baseline] (669.787 µs) : 0, 670
Remote Config [candidate] (675.185 µs) : 0, 675
Telemetry [baseline] (8.826 ms) : 0, 8826
Telemetry [candidate] (8.782 ms) : 0, 8782
IAST [baseline] (21.714 ms) : 0, 21714
IAST [candidate] (21.633 ms) : 0, 21633
section profiling
BytebuddyAgent [baseline] (704.843 ms) : 0, 704843
BytebuddyAgent [candidate] (709.142 ms) : 0, 709142
GlobalTracer [baseline] (349.581 ms) : 0, 349581
GlobalTracer [candidate] (350.43 ms) : 0, 350430
AppSec [baseline] (54.832 ms) : 0, 54832
AppSec [candidate] (54.044 ms) : 0, 54044
Remote Config [baseline] (709.156 µs) : 0, 709
Remote Config [candidate] (723.74 µs) : 0, 724
Telemetry [baseline] (8.777 ms) : 0, 8777
Telemetry [candidate] (8.677 ms) : 0, 8677
ProfilingAgent [baseline] (95.296 ms) : 0, 95296
ProfilingAgent [candidate] (95.398 ms) : 0, 95398
Profiling [baseline] (95.321 ms) : 0, 95321
Profiling [candidate] (95.423 ms) : 0, 95423
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~9b370b2dd7, baseline=1.46.0-SNAPSHOT~523df01c66
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054088
Total [baseline] (8.602 s) : 0, 8602135
Agent [candidate] (1.051 s) : 0, 1051058
Total [candidate] (8.628 s) : 0, 8627532
section iast
Agent [baseline] (1.193 s) : 0, 1193076
Total [baseline] (9.18 s) : 0, 9179878
Agent [candidate] (1.192 s) : 0, 1192176
Total [candidate] (9.186 s) : 0, 9186139
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1181608
Total [baseline] (9.156 s) : 0, 9155836
Agent [candidate] (1.185 s) : 0, 1184675
Total [candidate] (9.164 s) : 0, 9163613
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1180577
Total [baseline] (9.214 s) : 0, 9213821
Agent [candidate] (1.181 s) : 0, 1181052
Total [candidate] (9.211 s) : 0, 9211045
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~9b370b2dd7, baseline=1.46.0-SNAPSHOT~523df01c66
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.548 ms) : 0, 712548
BytebuddyAgent [candidate] (712.677 ms) : 0, 712677
GlobalTracer [baseline] (255.248 ms) : 0, 255248
GlobalTracer [candidate] (254.681 ms) : 0, 254681
AppSec [baseline] (55.632 ms) : 0, 55632
AppSec [candidate] (55.982 ms) : 0, 55982
Remote Config [baseline] (737.681 µs) : 0, 738
Remote Config [candidate] (743.211 µs) : 0, 743
Telemetry [baseline] (14.991 ms) : 0, 14991
Telemetry [candidate] (12.009 ms) : 0, 12009
section iast
BytebuddyAgent [baseline] (839.604 ms) : 0, 839604
BytebuddyAgent [candidate] (840.008 ms) : 0, 840008
GlobalTracer [baseline] (248.367 ms) : 0, 248367
GlobalTracer [candidate] (247.903 ms) : 0, 247903
AppSec [baseline] (58.671 ms) : 0, 58671
AppSec [candidate] (58.13 ms) : 0, 58130
Remote Config [baseline] (676.43 µs) : 0, 676
Remote Config [candidate] (670.604 µs) : 0, 671
Telemetry [baseline] (8.933 ms) : 0, 8933
Telemetry [candidate] (8.794 ms) : 0, 8794
IAST [baseline] (21.716 ms) : 0, 21716
IAST [candidate] (21.477 ms) : 0, 21477
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.766 ms) : 0, 830766
BytebuddyAgent [candidate] (833.261 ms) : 0, 833261
GlobalTracer [baseline] (246.744 ms) : 0, 246744
GlobalTracer [candidate] (246.937 ms) : 0, 246937
AppSec [baseline] (58.052 ms) : 0, 58052
AppSec [candidate] (58.455 ms) : 0, 58455
Remote Config [baseline] (671.626 µs) : 0, 672
Remote Config [candidate] (670.76 µs) : 0, 671
Telemetry [baseline] (8.822 ms) : 0, 8822
Telemetry [candidate] (8.826 ms) : 0, 8826
IAST [baseline] (21.552 ms) : 0, 21552
IAST [candidate] (21.485 ms) : 0, 21485
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.545 ms) : 0, 830545
BytebuddyAgent [candidate] (829.969 ms) : 0, 829969
GlobalTracer [baseline] (246.517 ms) : 0, 246517
GlobalTracer [candidate] (247.861 ms) : 0, 247861
AppSec [baseline] (58.036 ms) : 0, 58036
AppSec [candidate] (57.949 ms) : 0, 57949
Remote Config [baseline] (678.262 µs) : 0, 678
Remote Config [candidate] (671.796 µs) : 0, 672
Telemetry [baseline] (8.688 ms) : 0, 8688
Telemetry [candidate] (8.648 ms) : 0, 8648
IAST [baseline] (21.13 ms) : 0, 21130
IAST [candidate] (20.91 ms) : 0, 20910
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9b370b2dd7, baseline=1.46.0-SNAPSHOT~523df01c66
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1372
. : milestone, 1352,
appsec (1.747 ms) : 1723, 1771
. : milestone, 1747,
appsec_no_iast (1.76 ms) : 1737, 1782
. : milestone, 1760,
iast (1.518 ms) : 1494, 1541
. : milestone, 1518,
profiling (1.544 ms) : 1519, 1568
. : milestone, 1544,
tracing (1.497 ms) : 1473, 1521
. : milestone, 1497,
section candidate
no_agent (1.362 ms) : 1341, 1383
. : milestone, 1362,
appsec (1.754 ms) : 1731, 1778
. : milestone, 1754,
appsec_no_iast (1.748 ms) : 1724, 1772
. : milestone, 1748,
iast (1.495 ms) : 1471, 1520
. : milestone, 1495,
profiling (1.565 ms) : 1540, 1591
. : milestone, 1565,
tracing (1.49 ms) : 1466, 1513
. : milestone, 1490,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9b370b2dd7, baseline=1.46.0-SNAPSHOT~523df01c66
dateFormat X
axisFormat %s
section baseline
no_agent (376.722 µs) : 356, 397
. : milestone, 377,
iast (499.509 µs) : 478, 521
. : milestone, 500,
iast_FULL (742.903 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (551.328 µs) : 529, 574
. : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (504.328 µs) : 482, 526
. : milestone, 504,
iast_INACTIVE (454.876 µs) : 433, 476
. : milestone, 455,
iast_TELEMETRY_OFF (488.902 µs) : 467, 511
. : milestone, 489,
tracing (455.112 µs) : 434, 476
. : milestone, 455,
section candidate
no_agent (370.066 µs) : 350, 391
. : milestone, 370,
iast (503.217 µs) : 481, 525
. : milestone, 503,
iast_FULL (737.993 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (540.754 µs) : 519, 562
. : milestone, 541,
iast_HARDCODED_SECRET_DISABLED (501.757 µs) : 480, 523
. : milestone, 502,
iast_INACTIVE (452.245 µs) : 431, 474
. : milestone, 452,
iast_TELEMETRY_OFF (487.025 µs) : 466, 508
. : milestone, 487,
tracing (447.081 µs) : 426, 468
. : milestone, 447,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9b370b2dd7, baseline=1.46.0-SNAPSHOT~523df01c66
dateFormat X
axisFormat %s
section baseline
no_agent (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
appsec (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
iast (18.912 s) : 18912000, 18912000
. : milestone, 18912000,
iast_GLOBAL (17.728 s) : 17728000, 17728000
. : milestone, 17728000,
profiling (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
tracing (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
section candidate
no_agent (15.591 s) : 15591000, 15591000
. : milestone, 15591000,
appsec (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
iast (19.055 s) : 19055000, 19055000
. : milestone, 19055000,
iast_GLOBAL (18.133 s) : 18133000, 18133000
. : milestone, 18133000,
profiling (15.626 s) : 15626000, 15626000
. : milestone, 15626000,
tracing (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9b370b2dd7, baseline=1.46.0-SNAPSHOT~523df01c66
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.359 ms) : 2316, 2401
. : milestone, 2359,
iast (2.105 ms) : 2051, 2160
. : milestone, 2105,
iast_GLOBAL (2.153 ms) : 2099, 2208
. : milestone, 2153,
profiling (1.957 ms) : 1914, 2001
. : milestone, 1957,
tracing (1.941 ms) : 1899, 1983
. : milestone, 1941,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.362 ms) : 2319, 2404
. : milestone, 2362,
iast (2.106 ms) : 2052, 2160
. : milestone, 2106,
iast_GLOBAL (2.148 ms) : 2093, 2202
. : milestone, 2148,
profiling (1.955 ms) : 1912, 1998
. : milestone, 1955,
tracing (1.952 ms) : 1910, 1994
. : milestone, 1952,
|
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/impacted-tests
branch
from
January 16, 2025 17:49
0cfd616
to
8a25380
Compare
nikita-tkachenko-datadog
changed the title
Pass test source data to retry policy factory
Implement impacted tests detection
Jan 16, 2025
nikita-tkachenko-datadog
added
type: enhancement
and removed
tag: no release notes
Changes to exclude from release notes
type: refactoring
labels
Jan 16, 2025
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/impacted-tests
branch
2 times, most recently
from
January 20, 2025 18:13
5560829
to
3b7cc1e
Compare
…+ extract a no-op git client implementation to avoid spamming logs with exceptions in envs where git executable is not available
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/impacted-tests
branch
from
January 22, 2025 12:35
e6a5ff4
to
9b370b2
Compare
nikita-tkachenko-datadog
requested review from
juan-fernandez,
nayeem-kamal and
daniel-mohedano
and removed request for
a team,
nayeem-kamal and
juan-fernandez
January 22, 2025 13:51
daniel-mohedano
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Implements Impacted Tests Detection CI Visibility feature (milestones 1.X as defined in the RFC linked below):
test.is_modified:true
tagAdditional Details
https://docs.google.com/document/d/1oV3qRzfdEAOazjjzsA7z-yAFh8gPOMRQnf7EtIwhsKo/edit?tab=t.0#heading=h.rnd972k0hiye
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1389