Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign ci-app-libraries-java as owners of Weaver instrumentation #8256

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Assign ci-app-libraries-java as owners of Weaver instrumentation #8256

merged 2 commits into from
Jan 21, 2025

Conversation

daniel-mohedano
Copy link
Contributor

@daniel-mohedano daniel-mohedano commented Jan 20, 2025 •
edited by jira bot
Loading

What Does This Do

Assigns @DataDog/ci-app-libraries-java as codeowners for the Weaver instrumentation.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: SDTEST-1439

@daniel-mohedano daniel-mohedano added tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility labels Jan 20, 2025
@daniel-mohedano daniel-mohedano marked this pull request as ready for review January 20, 2025 15:52
@daniel-mohedano daniel-mohedano requested a review from a team as a code owner January 20, 2025 15:52
@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/weaver-codeowners
git_commit_date 1737387007 1737388123
git_commit_sha 441582a 2ddf43b
release_version 1.46.0-SNAPSHOT~441582ae47 1.46.0-SNAPSHOT~2ddf43bfcb
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737390484 1737390484
ci_job_id 772982845 772982845
ci_pipeline_id 53490793 53490793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~2ddf43bfcb, baseline=1.46.0-SNAPSHOT~441582ae47

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065736
Total [baseline] (8.627 s) : 0, 8627011
Agent [candidate] (1.063 s) : 0, 1063270
Total [candidate] (8.649 s) : 0, 8649368
section iast
Agent [baseline] (1.181 s) : 0, 1180955
Total [baseline] (9.202 s) : 0, 9202091
Agent [candidate] (1.193 s) : 0, 1192967
Total [candidate] (9.225 s) : 0, 9224583
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1180811
Total [baseline] (9.149 s) : 0, 9149013
Agent [candidate] (1.184 s) : 0, 1184161
Total [candidate] (9.164 s) : 0, 9164042
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1188010
Total [baseline] (9.185 s) : 0, 9185426
Agent [candidate] (1.19 s) : 0, 1190327
Total [candidate] (9.239 s) : 0, 9238828
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.181 s 115.219 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 115.075 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.188 s 122.274 ms (11.5%)
Total tracing 8.627 s -
Total iast 9.202 s 575.079 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.149 s 522.002 ms (6.1%)
Total iast_TELEMETRY_OFF 9.185 s 558.414 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.193 s 129.697 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 120.891 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.19 s 127.057 ms (11.9%)
Total tracing 8.649 s -
Total iast 9.225 s 575.215 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.164 s 514.674 ms (6.0%)
Total iast_TELEMETRY_OFF 9.239 s 589.46 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~2ddf43bfcb, baseline=1.46.0-SNAPSHOT~441582ae47

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.774 ms) : 0, 722774
BytebuddyAgent [candidate] (718.997 ms) : 0, 718997
GlobalTracer [baseline] (256.737 ms) : 0, 256737
GlobalTracer [candidate] (257.24 ms) : 0, 257240
AppSec [baseline] (55.735 ms) : 0, 55735
AppSec [candidate] (56.732 ms) : 0, 56732
Remote Config [baseline] (744.122 µs) : 0, 744
Remote Config [candidate] (746.998 µs) : 0, 747
Telemetry [baseline] (14.646 ms) : 0, 14646
Telemetry [candidate] (14.558 ms) : 0, 14558
section iast
BytebuddyAgent [baseline] (830.685 ms) : 0, 830685
BytebuddyAgent [candidate] (840.035 ms) : 0, 840035
GlobalTracer [baseline] (246.359 ms) : 0, 246359
GlobalTracer [candidate] (248.245 ms) : 0, 248245
AppSec [baseline] (58.064 ms) : 0, 58064
AppSec [candidate] (58.389 ms) : 0, 58389
IAST [baseline] (21.471 ms) : 0, 21471
IAST [candidate] (21.599 ms) : 0, 21599
Remote Config [baseline] (670.32 µs) : 0, 670
Remote Config [candidate] (672.18 µs) : 0, 672
Telemetry [baseline] (8.742 ms) : 0, 8742
Telemetry [candidate] (8.881 ms) : 0, 8881
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.476 ms) : 0, 830476
BytebuddyAgent [candidate] (833.109 ms) : 0, 833109
GlobalTracer [baseline] (246.187 ms) : 0, 246187
GlobalTracer [candidate] (246.722 ms) : 0, 246722
AppSec [baseline] (58.248 ms) : 0, 58248
AppSec [candidate] (58.138 ms) : 0, 58138
IAST [baseline] (21.527 ms) : 0, 21527
IAST [candidate] (21.612 ms) : 0, 21612
Remote Config [baseline] (661.919 µs) : 0, 662
Remote Config [candidate] (675.735 µs) : 0, 676
Telemetry [baseline] (8.725 ms) : 0, 8725
Telemetry [candidate] (8.812 ms) : 0, 8812
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.997 ms) : 0, 835997
BytebuddyAgent [candidate] (838.304 ms) : 0, 838304
GlobalTracer [baseline] (248.028 ms) : 0, 248028
GlobalTracer [candidate] (247.981 ms) : 0, 247981
AppSec [baseline] (58.195 ms) : 0, 58195
AppSec [candidate] (58.08 ms) : 0, 58080
IAST [baseline] (21.245 ms) : 0, 21245
IAST [candidate] (21.369 ms) : 0, 21369
Remote Config [baseline] (669.316 µs) : 0, 669
Remote Config [candidate] (680.391 µs) : 0, 680
Telemetry [baseline] (8.745 ms) : 0, 8745
Telemetry [candidate] (8.754 ms) : 0, 8754
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~2ddf43bfcb, baseline=1.46.0-SNAPSHOT~441582ae47

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055097
Total [baseline] (10.43 s) : 0, 10430124
Agent [candidate] (1.08 s) : 0, 1080436
Total [candidate] (10.537 s) : 0, 10536851
section appsec
Agent [baseline] (1.186 s) : 0, 1186223
Total [baseline] (10.686 s) : 0, 10686232
Agent [candidate] (1.188 s) : 0, 1187874
Total [candidate] (10.76 s) : 0, 10760440
section iast
Agent [baseline] (1.183 s) : 0, 1182661
Total [baseline] (10.967 s) : 0, 10966934
Agent [candidate] (1.181 s) : 0, 1180560
Total [candidate] (10.996 s) : 0, 10996328
section profiling
Agent [baseline] (1.26 s) : 0, 1260310
Total [baseline] (10.892 s) : 0, 10891551
Agent [candidate] (1.252 s) : 0, 1252060
Total [candidate] (10.827 s) : 0, 10826610
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.186 s 131.125 ms (12.4%)
Agent iast 1.183 s 127.563 ms (12.1%)
Agent profiling 1.26 s 205.213 ms (19.4%)
Total tracing 10.43 s -
Total appsec 10.686 s 256.108 ms (2.5%)
Total iast 10.967 s 536.81 ms (5.1%)
Total profiling 10.892 s 461.427 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.188 s 107.438 ms (9.9%)
Agent iast 1.181 s 100.124 ms (9.3%)
Agent profiling 1.252 s 171.624 ms (15.9%)
Total tracing 10.537 s -
Total appsec 10.76 s 223.589 ms (2.1%)
Total iast 10.996 s 459.477 ms (4.4%)
Total profiling 10.827 s 289.76 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~2ddf43bfcb, baseline=1.46.0-SNAPSHOT~441582ae47

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.397 ms) : 0, 714397
BytebuddyAgent [candidate] (732.269 ms) : 0, 732269
GlobalTracer [baseline] (255.327 ms) : 0, 255327
GlobalTracer [candidate] (261.424 ms) : 0, 261424
AppSec [baseline] (56.872 ms) : 0, 56872
AppSec [candidate] (56.883 ms) : 0, 56883
Remote Config [baseline] (735.086 µs) : 0, 735
Remote Config [candidate] (774.564 µs) : 0, 775
Telemetry [baseline] (12.853 ms) : 0, 12853
Telemetry [candidate] (13.762 ms) : 0, 13762
section appsec
BytebuddyAgent [baseline] (729.57 ms) : 0, 729570
BytebuddyAgent [candidate] (730.533 ms) : 0, 730533
GlobalTracer [baseline] (252.17 ms) : 0, 252170
GlobalTracer [candidate] (252.929 ms) : 0, 252929
AppSec [baseline] (170.539 ms) : 0, 170539
AppSec [candidate] (170.563 ms) : 0, 170563
Remote Config [baseline] (664.154 µs) : 0, 664
Remote Config [candidate] (661.603 µs) : 0, 662
Telemetry [baseline] (8.206 ms) : 0, 8206
Telemetry [candidate] (8.169 ms) : 0, 8169
IAST [baseline] (20.191 ms) : 0, 20191
IAST [candidate] (20.065 ms) : 0, 20065
section iast
BytebuddyAgent [baseline] (831.614 ms) : 0, 831614
BytebuddyAgent [candidate] (830.684 ms) : 0, 830684
GlobalTracer [baseline] (246.552 ms) : 0, 246552
GlobalTracer [candidate] (245.931 ms) : 0, 245931
AppSec [baseline] (58.352 ms) : 0, 58352
AppSec [candidate] (58.021 ms) : 0, 58021
Remote Config [baseline] (669.273 µs) : 0, 669
Remote Config [candidate] (665.34 µs) : 0, 665
Telemetry [baseline] (8.806 ms) : 0, 8806
Telemetry [candidate] (8.722 ms) : 0, 8722
IAST [baseline] (21.679 ms) : 0, 21679
IAST [candidate] (21.438 ms) : 0, 21438
section profiling
BytebuddyAgent [baseline] (706.687 ms) : 0, 706687
BytebuddyAgent [candidate] (702.211 ms) : 0, 702211
GlobalTracer [baseline] (350.687 ms) : 0, 350687
GlobalTracer [candidate] (349.593 ms) : 0, 349593
AppSec [baseline] (55.163 ms) : 0, 55163
AppSec [candidate] (54.156 ms) : 0, 54156
Remote Config [baseline] (719.248 µs) : 0, 719
Remote Config [candidate] (713.265 µs) : 0, 713
Telemetry [baseline] (8.884 ms) : 0, 8884
Telemetry [candidate] (8.802 ms) : 0, 8802
ProfilingAgent [baseline] (96.13 ms) : 0, 96130
ProfilingAgent [candidate] (94.799 ms) : 0, 94799
Profiling [baseline] (96.156 ms) : 0, 96156
Profiling [candidate] (94.823 ms) : 0, 94823
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-20T15:58:04 2025-01-20T16:05:12
git_branch master daniel.mohedano/weaver-codeowners
git_commit_date 1737387007 1737388123
git_commit_sha 441582a 2ddf43b
release_version 1.46.0-SNAPSHOT~441582ae47 1.46.0-SNAPSHOT~2ddf43bfcb
start_time 2025-01-20T15:57:50 2025-01-20T16:04:58
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737389473 1737389473
ci_job_id 772982846 772982846
ci_pipeline_id 53490793 53490793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-100.594µs; -47.454µs] or [-6.344%; -2.993%]		 unstable
[-436.258op/s; +664.178op/s] or [-14.724%; +22.416%]		 1.512ms 3076.923op/s 1.586ms 2962.963op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~2ddf43bfcb, baseline=1.46.0-SNAPSHOT~441582ae47
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1339, 1378
.   : milestone, 1358,
appsec (1.753 ms) : 1729, 1777
.   : milestone, 1753,
appsec_no_iast (1.779 ms) : 1756, 1802
.   : milestone, 1779,
iast (1.525 ms) : 1500, 1550
.   : milestone, 1525,
profiling (1.586 ms) : 1560, 1611
.   : milestone, 1586,
tracing (1.511 ms) : 1487, 1535
.   : milestone, 1511,
section candidate
no_agent (1.37 ms) : 1350, 1389
.   : milestone, 1370,
appsec (1.772 ms) : 1749, 1795
.   : milestone, 1772,
appsec_no_iast (1.775 ms) : 1751, 1798
.   : milestone, 1775,
iast (1.523 ms) : 1498, 1549
.   : milestone, 1523,
profiling (1.512 ms) : 1488, 1536
.   : milestone, 1512,
tracing (1.524 ms) : 1499, 1549
.   : milestone, 1524,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.339 ms, 1.378 ms] -
appsec 1.753 ms [1.729 ms, 1.777 ms] 394.716 µs (29.1%)
appsec_no_iast 1.779 ms [1.756 ms, 1.802 ms] 420.534 µs (31.0%)
iast 1.525 ms [1.5 ms, 1.55 ms] 166.638 µs (12.3%)
profiling 1.586 ms [1.56 ms, 1.611 ms] 227.266 µs (16.7%)
tracing 1.511 ms [1.487 ms, 1.535 ms] 152.438 µs (11.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.35 ms, 1.389 ms] -
appsec 1.772 ms [1.749 ms, 1.795 ms] 401.888 µs (29.3%)
appsec_no_iast 1.775 ms [1.751 ms, 1.798 ms] 404.821 µs (29.6%)
iast 1.523 ms [1.498 ms, 1.549 ms] 153.704 µs (11.2%)
profiling 1.512 ms [1.488 ms, 1.536 ms] 141.781 µs (10.4%)
tracing 1.524 ms [1.499 ms, 1.549 ms] 154.225 µs (11.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~2ddf43bfcb, baseline=1.46.0-SNAPSHOT~441582ae47
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.295 µs) : 362, 404
.   : milestone, 383,
iast (517.849 µs) : 496, 540
.   : milestone, 518,
iast_FULL (744.449 µs) : 723, 766
.   : milestone, 744,
iast_GLOBAL (570.148 µs) : 547, 593
.   : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (519.884 µs) : 498, 542
.   : milestone, 520,
iast_INACTIVE (462.608 µs) : 441, 484
.   : milestone, 463,
iast_TELEMETRY_OFF (498.821 µs) : 477, 520
.   : milestone, 499,
tracing (455.411 µs) : 435, 476
.   : milestone, 455,
section candidate
no_agent (391.843 µs) : 372, 412
.   : milestone, 392,
iast (513.135 µs) : 491, 535
.   : milestone, 513,
iast_FULL (750.377 µs) : 729, 772
.   : milestone, 750,
iast_GLOBAL (556.84 µs) : 535, 579
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (513.697 µs) : 492, 535
.   : milestone, 514,
iast_INACTIVE (461.157 µs) : 440, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (500.707 µs) : 479, 522
.   : milestone, 501,
tracing (452.911 µs) : 432, 473
.   : milestone, 453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.295 µs [362.461 µs, 404.128 µs] -
iast 517.849 µs [495.721 µs, 539.977 µs] 134.555 µs (35.1%)
iast_FULL 744.449 µs [722.659 µs, 766.239 µs] 361.155 µs (94.2%)
iast_GLOBAL 570.148 µs [547.141 µs, 593.155 µs] 186.854 µs (48.7%)
iast_HARDCODED_SECRET_DISABLED 519.884 µs [497.722 µs, 542.047 µs] 136.59 µs (35.6%)
iast_INACTIVE 462.608 µs [441.474 µs, 483.742 µs] 79.313 µs (20.7%)
iast_TELEMETRY_OFF 498.821 µs [477.233 µs, 520.409 µs] 115.527 µs (30.1%)
tracing 455.411 µs [434.886 µs, 475.936 µs] 72.116 µs (18.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 391.843 µs [371.647 µs, 412.04 µs] -
iast 513.135 µs [491.363 µs, 534.907 µs] 121.292 µs (31.0%)
iast_FULL 750.377 µs [728.6 µs, 772.154 µs] 358.534 µs (91.5%)
iast_GLOBAL 556.84 µs [535.072 µs, 578.609 µs] 164.997 µs (42.1%)
iast_HARDCODED_SECRET_DISABLED 513.697 µs [491.988 µs, 535.406 µs] 121.854 µs (31.1%)
iast_INACTIVE 461.157 µs [440.17 µs, 482.144 µs] 69.313 µs (17.7%)
iast_TELEMETRY_OFF 500.707 µs [479.001 µs, 522.413 µs] 108.864 µs (27.8%)
tracing 452.911 µs [432.384 µs, 473.438 µs] 61.068 µs (15.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/weaver-codeowners
git_commit_date 1737387007 1737388123
git_commit_sha 441582a 2ddf43b
release_version 1.46.0-SNAPSHOT~441582ae47 1.46.0-SNAPSHOT~2ddf43bfcb
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1737390001 1737390001
ci_job_id 772982847 772982847
ci_pipeline_id 53490793 53490793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~2ddf43bfcb, baseline=1.46.0-SNAPSHOT~441582ae47
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.029 s) : 15029000, 15029000
.   : milestone, 15029000,
appsec (15.112 s) : 15112000, 15112000
.   : milestone, 15112000,
iast (18.825 s) : 18825000, 18825000
.   : milestone, 18825000,
iast_GLOBAL (18.283 s) : 18283000, 18283000
.   : milestone, 18283000,
profiling (15.182 s) : 15182000, 15182000
.   : milestone, 15182000,
tracing (14.86 s) : 14860000, 14860000
.   : milestone, 14860000,
section candidate
no_agent (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
appsec (15.11 s) : 15110000, 15110000
.   : milestone, 15110000,
iast (18.836 s) : 18836000, 18836000
.   : milestone, 18836000,
iast_GLOBAL (17.693 s) : 17693000, 17693000
.   : milestone, 17693000,
profiling (15.08 s) : 15080000, 15080000
.   : milestone, 15080000,
tracing (14.752 s) : 14752000, 14752000
.   : milestone, 14752000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.029 s [15.029 s, 15.029 s] -
appsec 15.112 s [15.112 s, 15.112 s] 83.0 ms (0.6%)
iast 18.825 s [18.825 s, 18.825 s] 3.796 s (25.3%)
iast_GLOBAL 18.283 s [18.283 s, 18.283 s] 3.254 s (21.7%)
profiling 15.182 s [15.182 s, 15.182 s] 153.0 ms (1.0%)
tracing 14.86 s [14.86 s, 14.86 s] -169.0 ms (-1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.059 s [15.059 s, 15.059 s] -
appsec 15.11 s [15.11 s, 15.11 s] 51.0 ms (0.3%)
iast 18.836 s [18.836 s, 18.836 s] 3.777 s (25.1%)
iast_GLOBAL 17.693 s [17.693 s, 17.693 s] 2.634 s (17.5%)
profiling 15.08 s [15.08 s, 15.08 s] 21.0 ms (0.1%)
tracing 14.752 s [14.752 s, 14.752 s] -307.0 ms (-2.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~2ddf43bfcb, baseline=1.46.0-SNAPSHOT~441582ae47
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.369 ms) : 2325, 2412
.   : milestone, 2369,
iast (2.109 ms) : 2055, 2164
.   : milestone, 2109,
iast_GLOBAL (2.161 ms) : 2106, 2216
.   : milestone, 2161,
profiling (1.955 ms) : 1912, 1999
.   : milestone, 1955,
tracing (1.948 ms) : 1905, 1991
.   : milestone, 1948,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.357 ms) : 2314, 2399
.   : milestone, 2357,
iast (2.108 ms) : 2054, 2163
.   : milestone, 2108,
iast_GLOBAL (2.151 ms) : 2096, 2205
.   : milestone, 2151,
profiling (1.972 ms) : 1928, 2017
.   : milestone, 1972,
tracing (1.934 ms) : 1892, 1976
.   : milestone, 1934,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.464 ms, 1.487 ms] -
appsec 2.369 ms [2.325 ms, 2.412 ms] 892.812 µs (60.5%)
iast 2.109 ms [2.055 ms, 2.164 ms] 633.706 µs (42.9%)
iast_GLOBAL 2.161 ms [2.106 ms, 2.216 ms] 685.506 µs (46.5%)
profiling 1.955 ms [1.912 ms, 1.999 ms] 479.491 µs (32.5%)
tracing 1.948 ms [1.905 ms, 1.991 ms] 472.301 µs (32.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.357 ms [2.314 ms, 2.399 ms] 884.261 µs (60.1%)
iast 2.108 ms [2.054 ms, 2.163 ms] 635.986 µs (43.2%)
iast_GLOBAL 2.151 ms [2.096 ms, 2.205 ms] 678.226 µs (46.1%)
profiling 1.972 ms [1.928 ms, 2.017 ms] 500.144 µs (34.0%)
tracing 1.934 ms [1.892 ms, 1.976 ms] 461.602 µs (31.4%)

PerfectSlayer
PerfectSlayer approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow up PR 🙏

@daniel-mohedano daniel-mohedano merged commit b63b852 into master Jan 21, 2025
175 checks passed
@daniel-mohedano daniel-mohedano deleted the daniel.mohedano/weaver-codeowners branch January 21, 2025 08:45
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility tag: no release notes Changes to exclude from release notes type: documentation
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
4 participants
@daniel-mohedano @PerfectSlayer @manuel-alvarez-alvarez @nikita-tkachenko-datadog