🍒 8258 - Prevents a NPE when there is no subscriber for user events #8260

manuel-alvarez-alvarez · 2025-01-21T09:59:52Z

Backport #8258 to release/v1.45.x

(cherry picked from commit 4f83a4c)

github-actions · 2025-01-21T10:00:04Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Remove the tag from the pull request title

If you need help, please check our contributing guidelines.

pr-commenter · 2025-01-21T10:39:59Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/backport-pr-8258
git_commit_date	1737453496	1737453589
git_commit_sha	`01c83aa`	`d8a2ffc`
release_version	1.46.0-SNAPSHOT~01c83aa245	1.46.0-SNAPSHOT~d8a2ffcd1b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737456017	1737456017
ci_job_id	773602122	773602122
ci_pipeline_id	53529239	53529239
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 6 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:Remote Config	better [-62.343µs; -16.285µs] or [-8.898%; -2.324%]	661.289µs	700.603µs

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~d8a2ffcd1b, baseline=1.46.0-SNAPSHOT~01c83aa245

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069711
Total [baseline] (10.491 s) : 0, 10491190
Agent [candidate] (1.057 s) : 0, 1057027
Total [candidate] (10.466 s) : 0, 10466038
section appsec
Agent [baseline] (1.196 s) : 0, 1195932
Total [baseline] (10.744 s) : 0, 10744263
Agent [candidate] (1.187 s) : 0, 1186877
Total [candidate] (10.691 s) : 0, 10690850
section iast
Agent [baseline] (1.182 s) : 0, 1182401
Total [baseline] (11.025 s) : 0, 11025447
Agent [candidate] (1.188 s) : 0, 1188230
Total [candidate] (10.961 s) : 0, 10960846
section profiling
Agent [baseline] (1.252 s) : 0, 1252478
Total [baseline] (10.784 s) : 0, 10784211
Agent [candidate] (1.254 s) : 0, 1254031
Total [candidate] (10.807 s) : 0, 10807423

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.07 s	-
Agent	appsec	1.196 s	126.221 ms (11.8%)
Agent	iast	1.182 s	112.69 ms (10.5%)
Agent	profiling	1.252 s	182.767 ms (17.1%)
Total	tracing	10.491 s	-
Total	appsec	10.744 s	253.073 ms (2.4%)
Total	iast	11.025 s	534.257 ms (5.1%)
Total	profiling	10.784 s	293.022 ms (2.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.187 s	129.85 ms (12.3%)
Agent	iast	1.188 s	131.203 ms (12.4%)
Agent	profiling	1.254 s	197.004 ms (18.6%)
Total	tracing	10.466 s	-
Total	appsec	10.691 s	224.811 ms (2.1%)
Total	iast	10.961 s	494.807 ms (4.7%)
Total	profiling	10.807 s	341.385 ms (3.3%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~d8a2ffcd1b, baseline=1.46.0-SNAPSHOT~01c83aa245

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.83 ms) : 0, 723830
BytebuddyAgent [candidate] (713.974 ms) : 0, 713974
GlobalTracer [baseline] (258.601 ms) : 0, 258601
GlobalTracer [candidate] (255.7 ms) : 0, 255700
AppSec [baseline] (55.823 ms) : 0, 55823
AppSec [candidate] (55.811 ms) : 0, 55811
Remote Config [baseline] (748.179 µs) : 0, 748
Remote Config [candidate] (719.478 µs) : 0, 719
Telemetry [baseline] (15.526 ms) : 0, 15526
Telemetry [candidate] (15.794 ms) : 0, 15794
section appsec
BytebuddyAgent [baseline] (736.227 ms) : 0, 736227
BytebuddyAgent [candidate] (729.942 ms) : 0, 729942
GlobalTracer [baseline] (254.877 ms) : 0, 254877
GlobalTracer [candidate] (252.943 ms) : 0, 252943
AppSec [baseline] (170.934 ms) : 0, 170934
AppSec [candidate] (170.582 ms) : 0, 170582
IAST [baseline] (20.077 ms) : 0, 20077
IAST [candidate] (19.184 ms) : 0, 19184
Remote Config [baseline] (654.657 µs) : 0, 655
Remote Config [candidate] (649.031 µs) : 0, 649
Telemetry [baseline] (8.155 ms) : 0, 8155
Telemetry [candidate] (8.174 ms) : 0, 8174
section iast
BytebuddyAgent [baseline] (831.91 ms) : 0, 831910
BytebuddyAgent [candidate] (836.027 ms) : 0, 836027
GlobalTracer [baseline] (246.266 ms) : 0, 246266
GlobalTracer [candidate] (248.042 ms) : 0, 248042
AppSec [baseline] (58.138 ms) : 0, 58138
AppSec [candidate] (58.11 ms) : 0, 58110
IAST [baseline] (21.719 ms) : 0, 21719
IAST [candidate] (21.464 ms) : 0, 21464
Remote Config [baseline] (677.675 µs) : 0, 678
Remote Config [candidate] (660.394 µs) : 0, 660
Telemetry [baseline] (8.736 ms) : 0, 8736
Telemetry [candidate] (8.791 ms) : 0, 8791
section profiling
BytebuddyAgent [baseline] (702.557 ms) : 0, 702557
BytebuddyAgent [candidate] (702.693 ms) : 0, 702693
GlobalTracer [baseline] (347.831 ms) : 0, 347831
GlobalTracer [candidate] (350.608 ms) : 0, 350608
AppSec [baseline] (55.389 ms) : 0, 55389
AppSec [candidate] (53.614 ms) : 0, 53614
Remote Config [baseline] (700.603 µs) : 0, 701
Remote Config [candidate] (661.289 µs) : 0, 661
Telemetry [baseline] (8.7 ms) : 0, 8700
Telemetry [candidate] (9.175 ms) : 0, 9175
ProfilingAgent [baseline] (95.452 ms) : 0, 95452
ProfilingAgent [candidate] (95.371 ms) : 0, 95371
Profiling [baseline] (95.477 ms) : 0, 95477
Profiling [candidate] (95.395 ms) : 0, 95395

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~d8a2ffcd1b, baseline=1.46.0-SNAPSHOT~01c83aa245

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055755
Total [baseline] (8.616 s) : 0, 8616306
Agent [candidate] (1.053 s) : 0, 1052515
Total [candidate] (8.625 s) : 0, 8625059
section iast
Agent [baseline] (1.198 s) : 0, 1198240
Total [baseline] (9.195 s) : 0, 9195264
Agent [candidate] (1.183 s) : 0, 1182641
Total [candidate] (9.177 s) : 0, 9177090
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1181811
Total [baseline] (9.157 s) : 0, 9157371
Agent [candidate] (1.182 s) : 0, 1181576
Total [candidate] (9.154 s) : 0, 9153987
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175404
Total [baseline] (9.156 s) : 0, 9156111
Agent [candidate] (1.186 s) : 0, 1185767
Total [candidate] (9.255 s) : 0, 9255027

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.056 s	-
Agent	iast	1.198 s	142.484 ms (13.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.182 s	126.055 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.175 s	119.649 ms (11.3%)
Total	tracing	8.616 s	-
Total	iast	9.195 s	578.958 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.157 s	541.065 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.156 s	539.805 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.183 s	130.126 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.182 s	129.062 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.186 s	133.252 ms (12.7%)
Total	tracing	8.625 s	-
Total	iast	9.177 s	552.031 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.154 s	528.928 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.255 s	629.967 ms (7.3%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~d8a2ffcd1b, baseline=1.46.0-SNAPSHOT~01c83aa245

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.702 ms) : 0, 712702
BytebuddyAgent [candidate] (711.491 ms) : 0, 711491
GlobalTracer [baseline] (255.104 ms) : 0, 255104
GlobalTracer [candidate] (255.801 ms) : 0, 255801
AppSec [baseline] (56.282 ms) : 0, 56282
AppSec [candidate] (55.775 ms) : 0, 55775
Remote Config [baseline] (724.897 µs) : 0, 725
Remote Config [candidate] (729.173 µs) : 0, 729
Telemetry [baseline] (15.94 ms) : 0, 15940
Telemetry [candidate] (13.654 ms) : 0, 13654
section iast
BytebuddyAgent [baseline] (844.182 ms) : 0, 844182
BytebuddyAgent [candidate] (831.843 ms) : 0, 831843
GlobalTracer [baseline] (249.199 ms) : 0, 249199
GlobalTracer [candidate] (247.409 ms) : 0, 247409
AppSec [baseline] (58.639 ms) : 0, 58639
AppSec [candidate] (57.94 ms) : 0, 57940
IAST [baseline] (21.59 ms) : 0, 21590
IAST [candidate] (21.145 ms) : 0, 21145
Remote Config [baseline] (673.254 µs) : 0, 673
Remote Config [candidate] (667.87 µs) : 0, 668
Telemetry [baseline] (8.845 ms) : 0, 8845
Telemetry [candidate] (8.655 ms) : 0, 8655
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.261 ms) : 0, 831261
BytebuddyAgent [candidate] (831.207 ms) : 0, 831207
GlobalTracer [baseline] (246.39 ms) : 0, 246390
GlobalTracer [candidate] (247.0 ms) : 0, 247000
AppSec [baseline] (58.323 ms) : 0, 58323
AppSec [candidate] (58.017 ms) : 0, 58017
IAST [baseline] (21.424 ms) : 0, 21424
IAST [candidate] (20.981 ms) : 0, 20981
Remote Config [baseline] (677.6 µs) : 0, 678
Remote Config [candidate] (657.971 µs) : 0, 658
Telemetry [baseline] (8.714 ms) : 0, 8714
Telemetry [candidate] (8.645 ms) : 0, 8645
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (826.159 ms) : 0, 826159
BytebuddyAgent [candidate] (834.037 ms) : 0, 834037
GlobalTracer [baseline] (245.923 ms) : 0, 245923
GlobalTracer [candidate] (248.252 ms) : 0, 248252
AppSec [baseline] (58.104 ms) : 0, 58104
AppSec [candidate] (58.04 ms) : 0, 58040
IAST [baseline] (20.978 ms) : 0, 20978
IAST [candidate] (21.066 ms) : 0, 21066
Remote Config [baseline] (669.219 µs) : 0, 669
Remote Config [candidate] (657.603 µs) : 0, 658
Telemetry [baseline] (8.614 ms) : 0, 8614
Telemetry [candidate] (8.641 ms) : 0, 8641

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-21T10:10:23	2025-01-21T10:17:28
git_branch	master	malvarez/backport-pr-8258
git_commit_date	1737453496	1737453589
git_commit_sha	`01c83aa`	`d8a2ffc`
release_version	1.46.0-SNAPSHOT~01c83aa245	1.46.0-SNAPSHOT~d8a2ffcd1b
start_time	2025-01-21T10:10:09	2025-01-21T10:17:15

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1737455002	1737455002
ci_job_id	773602123	773602123
ci_pipeline_id	53529239	53529239
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_FULL	better [-109.593µs; -62.572µs] or [-14.669%; -8.375%]	unstable [-368.148op/s; +2272.910op/s] or [-6.443%; +39.776%]	661.028µs	6666.667op/s	747.111µs	5714.286op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d8a2ffcd1b, baseline=1.46.0-SNAPSHOT~01c83aa245
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.376 ms) : 1356, 1395
.   : milestone, 1376,
appsec (1.758 ms) : 1734, 1783
.   : milestone, 1758,
appsec_no_iast (1.752 ms) : 1728, 1775
.   : milestone, 1752,
iast (1.531 ms) : 1508, 1555
.   : milestone, 1531,
profiling (1.542 ms) : 1517, 1566
.   : milestone, 1542,
tracing (1.496 ms) : 1471, 1522
.   : milestone, 1496,
section candidate
no_agent (1.371 ms) : 1351, 1391
.   : milestone, 1371,
appsec (1.751 ms) : 1728, 1774
.   : milestone, 1751,
appsec_no_iast (1.753 ms) : 1729, 1777
.   : milestone, 1753,
iast (1.487 ms) : 1464, 1510
.   : milestone, 1487,
profiling (1.498 ms) : 1475, 1522
.   : milestone, 1498,
tracing (1.47 ms) : 1444, 1496
.   : milestone, 1470,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.376 ms [1.356 ms, 1.395 ms]	-
appsec	1.758 ms [1.734 ms, 1.783 ms]	382.718 µs (27.8%)
appsec_no_iast	1.752 ms [1.728 ms, 1.775 ms]	376.137 µs (27.3%)
iast	1.531 ms [1.508 ms, 1.555 ms]	155.887 µs (11.3%)
profiling	1.542 ms [1.517 ms, 1.566 ms]	166.349 µs (12.1%)
tracing	1.496 ms [1.471 ms, 1.522 ms]	120.748 µs (8.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.371 ms [1.351 ms, 1.391 ms]	-
appsec	1.751 ms [1.728 ms, 1.774 ms]	379.458 µs (27.7%)
appsec_no_iast	1.753 ms [1.729 ms, 1.777 ms]	381.897 µs (27.9%)
iast	1.487 ms [1.464 ms, 1.51 ms]	116.011 µs (8.5%)
profiling	1.498 ms [1.475 ms, 1.522 ms]	127.396 µs (9.3%)
tracing	1.47 ms [1.444 ms, 1.496 ms]	99.213 µs (7.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d8a2ffcd1b, baseline=1.46.0-SNAPSHOT~01c83aa245
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.645 µs) : 364, 403
.   : milestone, 384,
iast (508.375 µs) : 487, 530
.   : milestone, 508,
iast_FULL (747.111 µs) : 725, 769
.   : milestone, 747,
iast_GLOBAL (556.654 µs) : 534, 579
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (510.471 µs) : 489, 532
.   : milestone, 510,
iast_INACTIVE (458.926 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (501.005 µs) : 479, 523
.   : milestone, 501,
tracing (452.394 µs) : 431, 473
.   : milestone, 452,
section candidate
no_agent (377.316 µs) : 357, 397
.   : milestone, 377,
iast (489.166 µs) : 468, 511
.   : milestone, 489,
iast_FULL (661.028 µs) : 639, 683
.   : milestone, 661,
iast_GLOBAL (531.987 µs) : 509, 555
.   : milestone, 532,
iast_HARDCODED_SECRET_DISABLED (497.106 µs) : 474, 521
.   : milestone, 497,
iast_INACTIVE (459.11 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (487.394 µs) : 466, 509
.   : milestone, 487,
tracing (458.733 µs) : 437, 480
.   : milestone, 459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.645 µs [364.017 µs, 403.273 µs]	-
iast	508.375 µs [486.573 µs, 530.177 µs]	124.73 µs (32.5%)
iast_FULL	747.111 µs [725.049 µs, 769.172 µs]	363.466 µs (94.7%)
iast_GLOBAL	556.654 µs [534.161 µs, 579.146 µs]	173.009 µs (45.1%)
iast_HARDCODED_SECRET_DISABLED	510.471 µs [488.898 µs, 532.044 µs]	126.826 µs (33.1%)
iast_INACTIVE	458.926 µs [437.639 µs, 480.212 µs]	75.281 µs (19.6%)
iast_TELEMETRY_OFF	501.005 µs [479.281 µs, 522.73 µs]	117.361 µs (30.6%)
tracing	452.394 µs [431.461 µs, 473.327 µs]	68.749 µs (17.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.316 µs [357.291 µs, 397.341 µs]	-
iast	489.166 µs [467.781 µs, 510.551 µs]	111.85 µs (29.6%)
iast_FULL	661.028 µs [639.396 µs, 682.66 µs]	283.712 µs (75.2%)
iast_GLOBAL	531.987 µs [509.18 µs, 554.794 µs]	154.671 µs (41.0%)
iast_HARDCODED_SECRET_DISABLED	497.106 µs [473.687 µs, 520.524 µs]	119.79 µs (31.7%)
iast_INACTIVE	459.11 µs [438.171 µs, 480.048 µs]	81.794 µs (21.7%)
iast_TELEMETRY_OFF	487.394 µs [465.658 µs, 509.131 µs]	110.078 µs (29.2%)
tracing	458.733 µs [437.093 µs, 480.373 µs]	81.417 µs (21.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/backport-pr-8258
git_commit_date	1737453496	1737453589
git_commit_sha	`01c83aa`	`d8a2ffc`
release_version	1.46.0-SNAPSHOT~01c83aa245	1.46.0-SNAPSHOT~d8a2ffcd1b

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1737455530	1737455530
ci_job_id	773602124	773602124
ci_pipeline_id	53529239	53529239
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d8a2ffcd1b, baseline=1.46.0-SNAPSHOT~01c83aa245
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.363 s) : 15363000, 15363000
.   : milestone, 15363000,
appsec (14.887 s) : 14887000, 14887000
.   : milestone, 14887000,
iast (18.582 s) : 18582000, 18582000
.   : milestone, 18582000,
iast_GLOBAL (17.887 s) : 17887000, 17887000
.   : milestone, 17887000,
profiling (15.096 s) : 15096000, 15096000
.   : milestone, 15096000,
tracing (14.855 s) : 14855000, 14855000
.   : milestone, 14855000,
section candidate
no_agent (15.54 s) : 15540000, 15540000
.   : milestone, 15540000,
appsec (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,
iast (18.955 s) : 18955000, 18955000
.   : milestone, 18955000,
iast_GLOBAL (17.94 s) : 17940000, 17940000
.   : milestone, 17940000,
profiling (15.731 s) : 15731000, 15731000
.   : milestone, 15731000,
tracing (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.363 s [15.363 s, 15.363 s]	-
appsec	14.887 s [14.887 s, 14.887 s]	-476.0 ms (-3.1%)
iast	18.582 s [18.582 s, 18.582 s]	3.219 s (21.0%)
iast_GLOBAL	17.887 s [17.887 s, 17.887 s]	2.524 s (16.4%)
profiling	15.096 s [15.096 s, 15.096 s]	-267.0 ms (-1.7%)
tracing	14.855 s [14.855 s, 14.855 s]	-508.0 ms (-3.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.54 s [15.54 s, 15.54 s]	-
appsec	15.014 s [15.014 s, 15.014 s]	-526.0 ms (-3.4%)
iast	18.955 s [18.955 s, 18.955 s]	3.415 s (22.0%)
iast_GLOBAL	17.94 s [17.94 s, 17.94 s]	2.4 s (15.4%)
profiling	15.731 s [15.731 s, 15.731 s]	191.0 ms (1.2%)
tracing	15.016 s [15.016 s, 15.016 s]	-524.0 ms (-3.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d8a2ffcd1b, baseline=1.46.0-SNAPSHOT~01c83aa245
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.35 ms) : 2307, 2393
.   : milestone, 2350,
iast (2.088 ms) : 2034, 2142
.   : milestone, 2088,
iast_GLOBAL (2.134 ms) : 2079, 2188
.   : milestone, 2134,
profiling (1.947 ms) : 1904, 1990
.   : milestone, 1947,
tracing (1.936 ms) : 1894, 1978
.   : milestone, 1936,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.335 ms) : 2293, 2378
.   : milestone, 2335,
iast (2.09 ms) : 2036, 2143
.   : milestone, 2090,
iast_GLOBAL (2.134 ms) : 2080, 2189
.   : milestone, 2134,
profiling (1.971 ms) : 1926, 2016
.   : milestone, 1971,
tracing (1.936 ms) : 1894, 1978
.   : milestone, 1936,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.451 ms, 1.474 ms]	-
appsec	2.35 ms [2.307 ms, 2.393 ms]	887.202 µs (60.7%)
iast	2.088 ms [2.034 ms, 2.142 ms]	625.136 µs (42.7%)
iast_GLOBAL	2.134 ms [2.079 ms, 2.188 ms]	671.106 µs (45.9%)
profiling	1.947 ms [1.904 ms, 1.99 ms]	484.449 µs (33.1%)
tracing	1.936 ms [1.894 ms, 1.978 ms]	473.602 µs (32.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.455 ms, 1.478 ms]	-
appsec	2.335 ms [2.293 ms, 2.378 ms]	868.648 µs (59.2%)
iast	2.09 ms [2.036 ms, 2.143 ms]	622.965 µs (42.5%)
iast_GLOBAL	2.134 ms [2.08 ms, 2.189 ms]	667.649 µs (45.5%)
profiling	1.971 ms [1.926 ms, 2.016 ms]	504.171 µs (34.4%)
tracing	1.936 ms [1.894 ms, 1.978 ms]	469.193 µs (32.0%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.jetbrains:annotations](https://github.com/JetBrains/java-annotations) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `26.0.1` -> `26.0.2` | | [io.grpc:grpc-stub](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.69.1` -> `1.70.0` | | [io.grpc:grpc-protobuf](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.69.1` -> `1.70.0` | | [io.grpc:grpc-netty](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.69.1` -> `1.70.0` | | [io.grpc:protoc-gen-grpc-java](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.69.1` -> `1.70.0` | | [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.69.1` -> `1.70.0` | | [io.grpc:grpc-api](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.69.1` -> `1.70.0` | | [com.google.api-client:google-api-client](https://github.com/googleapis/google-api-java-client) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.7.1` -> `2.7.2` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.0.0` -> `5.2.1` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.0.0` -> `5.2.1` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.0.0` -> `5.2.1` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.0.0` -> `5.2.1` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.0.0` -> `5.2.1` | | [com.squareup.wire:wire-gradle-plugin](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.0.0` -> `5.2.1` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.0.0` -> `5.2.1` | | [com.google.auth:google-auth-library-oauth2-http](https://github.com/googleapis/google-auth-library-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.30.1` -> `1.31.0` | | [com.google.auth:google-auth-library-credentials](https://github.com/googleapis/google-auth-library-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.30.1` -> `1.31.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.1` -> `1.45.2` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.1` -> `1.45.2` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.2` -> `2.30.4` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.2` -> `2.30.4` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.2` -> `2.30.4` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.2` -> `2.30.4` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.2` -> `2.30.4` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.2` -> `2.30.4` | --- ### Release Notes <details> <summary>JetBrains/java-annotations (org.jetbrains:annotations)</summary> ### [`v26.0.2`](https://github.com/JetBrains/java-annotations/blob/HEAD/CHANGELOG.md#Version-2602) [Compare Source](JetBrains/java-annotations@26.0.1...26.0.2) - Fixed missing klibs for apple artifacts. </details> <details> <summary>googleapis/google-api-java-client (com.google.api-client:google-api-client)</summary> ### [`v2.7.2`](https://github.com/googleapis/google-api-java-client/blob/HEAD/CHANGELOG.md#272-2025-01-22) ##### Bug Fixes - Add warnings to users about using credentials from external sources ([#2551](googleapis/google-api-java-client#2551)) ([3bb2879](googleapis/google-api-java-client@3bb2879)) </details> <details> <summary>square/wire (com.squareup.wire:wire-schema)</summary> ### [`v5.2.1`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-521) [Compare Source](square/wire@5.2.0...5.2.1) *2025-01-07* ##### JVM generation - Fix support for mutable messages in Wire's Kotlin Generator. ([#3233](square/wire#3233) by \[Rahul Ravikumar]\[tikurahul]) ### [`v5.2.0`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-520) [Compare Source](square/wire@5.1.0...5.2.0) *2025-01-06* ##### Common - Enforce recursion limit when parsing nested groups. ([#3119](square/wire#3119)) ##### CLI `wire-compiler` - It is now possible to set multiple targets. ([#3106](square/wire#3106) & [#3107](square/wire#3107)) - The option `opaque_types` introduced in `4.9.2` for the Wire Gradle plugin is now available on CLI. ([#3147](square/wire#3147)) ##### JVM generation - [KotlinPoet has been updated to `2.0.0`](https://square.github.io/kotlinpoet/changelog/#version-200) which dramatically changes how generated Kotlin files are wrapped. This is neither a source nor a binary breaking changes. - A new `@WireEnclosingType` annotation is now applied to generated types so R8 doesn't prune too much. ([#3123](square/wire#3123)) - Split the redact method into chunks when a type has more than 100 fields to avoid compilation error. ([#3214](square/wire#3214) by \[Damian Wieczorek]\[damianw]) - Add support for mutable messages in Wire's Kotlin Generator. ([#3217](square/wire#3217) by \[Rahul Ravikumar]\[tikurahul]) - You can opt-in by adding `mutableTypes = true` on your Kotlin target. This is unsafe and we do not recommend that you use it unless you have a sound use-case for it. - Wire is now using Palantir's JavaPoet instead of Square's JavaPoet. ##### Swift - Fix buffer overflow and data corruption when a type has more than 5 layers of nesting ([#3203](square/wire#3203) by \[Eric Amorde]\[amorde]) ### [`v5.1.0`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-510) [Compare Source](square/wire@5.0.0...5.1.0) *2024-09-11* ##### Common - Support for Kotlin `2.0.20`. ([#3093](square/wire#3093)) - `srcDir(String)` has been undeprecated. ([#3039](square/wire#3039)) - Some loggings now happen at the debug level, instead of info. ([#3041](square/wire#3041)) - Remove some unactionable warnings on Kotlin/JS ([#3047](square/wire#3047)) - Propagate the deprecated flag on EnumType after pruning by wire-gradle-plugin ([#3076](square/wire#3076) by \[Aaron Edwards]\[aaron-edwards]) - Introduce `ProtoReader32`, a specialization for Kotlin/JS ([#3077](square/wire#3077)) This is an alternative to `ProtoReader`, which uses `Long` as a cursor. It originates as an optimization for Kotlin/JS, where `Long` cursors are prohibitively expensive. - Fix Gradle project isolation issue when reading a property ([#3078](square/wire#3078) by \[Aurimas]\[liutikas]) - Change the recursion limit to match grpc's default ([#3091](square/wire#3091)) ##### Kotlin - New enum option `enum_mode` to take precedence over the `enumMode` option added in `5.0.0-alpha02`. Use this if you want to migrate your enums granularly. ([#2993](square/wire#2993)) - Don't throw if reading trailers fail ([#3087](square/wire#3087)) ##### Swift - Avoid crash when parsing an empty repeated `[packed=true]` for fixed-length types. ([#3044](square/wire#3044) by \[Sasha Weiss]\[sashaweiss-signal]) </details> <details> <summary>googleapis/google-auth-library-java (com.google.auth:google-auth-library-oauth2-http)</summary> ### [`v1.31.0`](https://github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1310-2025-01-22) ##### Features - ImpersonatedCredentials to support universe domain for idtoken and signblob ([#1566](googleapis/google-auth-library-java#1566)) ([adc2ff3](googleapis/google-auth-library-java@adc2ff3)) - Support transport and binding-enforcement MDS parameters. ([#1558](googleapis/google-auth-library-java#1558)) ([9828a8e](googleapis/google-auth-library-java@9828a8e)) ##### Documentation - Promote use of bill of materials in quickstart documentation ([#1620](googleapis/google-auth-library-java#1620)) ([fc20d9c](googleapis/google-auth-library-java@fc20d9c)), closes [#1552](googleapis/google-auth-library-java#1552) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.45.2`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.2): 1.45.2 ##### Components ##### Application Security Management (WAF) - 🐛 🍒 8258 - Prevents a NPE when there is no subscriber for user events ([#8260](DataDog/dd-trace-java#8260) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 12db0f59db2e6ebf55203c87fccab042d495106a

Fix NPE when there is no subscriber for user events

d8a2ffc

(cherry picked from commit 4f83a4c)

manuel-alvarez-alvarez requested a review from a team as a code owner January 21, 2025 09:59

manuel-alvarez-alvarez added type: bug comp: asm waf Application Security Management (WAF) labels Jan 21, 2025

manuel-alvarez-alvarez requested review from smola and jandro996 January 21, 2025 09:59

manuel-alvarez-alvarez changed the title ~~[🍒 8258] Prevents a NPE when there is no subscriber for user events~~ 🍒 8258 - Prevents a NPE when there is no subscriber for user events Jan 21, 2025

manuel-alvarez-alvarez added this to the 1.45.2 milestone Jan 21, 2025

PerfectSlayer approved these changes Jan 21, 2025

View reviewed changes

smola approved these changes Jan 21, 2025

View reviewed changes

manuel-alvarez-alvarez merged commit 400277e into release/v1.45.x Jan 21, 2025
149 of 151 checks passed

manuel-alvarez-alvarez deleted the malvarez/backport-pr-8258 branch January 21, 2025 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🍒 8258 - Prevents a NPE when there is no subscriber for user events #8260

🍒 8258 - Prevents a NPE when there is no subscriber for user events #8260

manuel-alvarez-alvarez commented Jan 21, 2025

github-actions bot commented Jan 21, 2025 •

edited

Loading

pr-commenter bot commented Jan 21, 2025 •

edited

Loading

🍒 8258 - Prevents a NPE when there is no subscriber for user events #8260

🍒 8258 - Prevents a NPE when there is no subscriber for user events #8260

Conversation

manuel-alvarez-alvarez commented Jan 21, 2025

github-actions bot commented Jan 21, 2025 • edited Loading

pr-commenter bot commented Jan 21, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

github-actions bot commented Jan 21, 2025 •

edited

Loading

pr-commenter bot commented Jan 21, 2025 •

edited

Loading