Missing decrement function in NoopDogStatsDClient #4285
Comments
tlhunter
pushed a commit
that referenced
this issue
Feb 27, 2025
I ported an open PR and added additional fixes to the code. The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. The `DogStatsDClient` is also missing the decrement method. Instead, the increment method was used by the the custom metric implementation. This is adjusted. Please check the commit messages for further information. Fixes #4285 Closes #5241 The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. --------- Co-authored-by: Justin Johnson <[email protected]>
juan-fernandez
pushed a commit
that referenced
this issue
Feb 28, 2025
I ported an open PR and added additional fixes to the code. The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. The `DogStatsDClient` is also missing the decrement method. Instead, the increment method was used by the the custom metric implementation. This is adjusted. Please check the commit messages for further information. Fixes #4285 Closes #5241 The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. --------- Co-authored-by: Justin Johnson <[email protected]>
juan-fernandez
pushed a commit
that referenced
this issue
Feb 28, 2025
I ported an open PR and added additional fixes to the code. The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. The `DogStatsDClient` is also missing the decrement method. Instead, the increment method was used by the the custom metric implementation. This is adjusted. Please check the commit messages for further information. Fixes #4285 Closes #5241 The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. --------- Co-authored-by: Justin Johnson <[email protected]>
juan-fernandez
pushed a commit
that referenced
this issue
Feb 28, 2025
I ported an open PR and added additional fixes to the code. The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. The `DogStatsDClient` is also missing the decrement method. Instead, the increment method was used by the the custom metric implementation. This is adjusted. Please check the commit messages for further information. Fixes #4285 Closes #5241 The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. --------- Co-authored-by: Justin Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of v5.12.0 the noop implementation of DogStatsDClient used in the NoopProxy is missing the decrement function, see https://github.com/DataDog/dd-trace-js/blob/v5.12.0/packages/dd-trace/src/noop/dogstatsd.js
The text was updated successfully, but these errors were encountered: