Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DD_VERSION as version for tracer computed stats if available #4720

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

duncanpharvey
Copy link
Contributor

What does this PR do?

If available, use the value in the DD_VERSION environment variable provided by the end user on trace metrics.

Motivation

This version tag on all trace metrics in Azure Functions is set to 3.10.0 regardless of the value in the DD_VERSION environment variable.

https://datadoghq.atlassian.net/browse/SVLS-5074

Additional Notes

The 3.10.0 value comes from this package: https://github.com/Azure/azure-functions-nodejs-worker.

Copy link

github-actions bot commented Sep 24, 2024

Overall package size

Self size: 7.18 MB
Deduped: 62.54 MB
No deduping: 62.82 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2024

Benchmarks

Benchmark execution time: 2024-09-26 20:03:59

Comparing candidate commit f59ee38 in PR branch duncan-harvey/tracer-computed-stats-version with baseline commit 1d2543c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@duncanpharvey duncanpharvey marked this pull request as ready for review September 25, 2024 16:19
@duncanpharvey duncanpharvey requested a review from a team as a code owner September 25, 2024 16:19
@Qard Qard merged commit c0ffabd into master Sep 26, 2024
192 checks passed
@Qard Qard deleted the duncan-harvey/tracer-computed-stats-version branch September 26, 2024 20:23
juan-fernandez pushed a commit that referenced this pull request Sep 30, 2024
* use DD_VERSION as version for tracer computed stats if available

* test version for tracer computed stats
juan-fernandez pushed a commit that referenced this pull request Sep 30, 2024
* use DD_VERSION as version for tracer computed stats if available

* test version for tracer computed stats
juan-fernandez pushed a commit that referenced this pull request Oct 1, 2024
* use DD_VERSION as version for tracer computed stats if available

* test version for tracer computed stats
juan-fernandez pushed a commit that referenced this pull request Oct 1, 2024
* use DD_VERSION as version for tracer computed stats if available

* test version for tracer computed stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants