Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.27.0 proposal #4925

Merged
merged 13 commits into from
Nov 21, 2024
Merged

v5.27.0 proposal #4925

merged 13 commits into from
Nov 21, 2024

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Nov 21, 2024

  • [fcc318497b] - (SEMVER-PATCH) fix langchain tests trying to run on unsupported node (Roch Devost) #4926
  • [f64f306790] - (SEMVER-PATCH) fix missing commands in denylist by allowing all (Roch Devost) #4922
  • [0bd54869a5] - (SEMVER-PATCH) add package manager symlinks to denylist (Bryan English) #4921
  • [0bade65244] - (SEMVER-PATCH) update crashtracker timeout to 5 seconds (Roch Devost) #4920
  • [6080dfa24c] - (SEMVER-PATCH) Abstract the passing of extracted header span links to startSpan (mhlidd) #4918
  • [d0e80ea9b7] - (SEMVER-PATCH) next.js: complete v14.x compatibility (fixing >=14.2.7) (Thomas Hunter II) #4916
  • [747cd5078f] - (SEMVER-PATCH) [ASM] Discard inferred spans when resolving the root span of a trace (Igor Unanua) #4881
  • [70a2c22330] - (SEMVER-PATCH) fix crashtracker not working with uds (Roch Devost) #4917
  • [c8ab3e4440] - (SEMVER-MINOR) [MLOB-1804] feat(langchain): add langchain instrumentation (Sam Brenner) #4860
  • [7408b1c04d] - (SEMVER-MINOR) Add profiler API telemetry metrics (Attila Szegedi) #4832
  • [204eb3514b] - (SEMVER-PATCH) fix release notes always flagged as latest (Roch Devost) #4910
  • [04ad3927cd] - (SEMVER-PATCH) fix release script hanging on applying new changes (Roch Devost) #4908

rochdev and others added 11 commits November 21, 2024 15:23
* Add profiler API telemetry metrics

* Reduce related errors to warnings so they aren't sent over telemetry logs
* wip

* wip

* first pass at chain invoke and chat,llm generate

* add langchain openai embeddings

* add batch call

* change api key logic

* testing

* ts def changes

* codeowners changes

* add clarifying issue as reason for skipping esm tests

* fix langchain patching for possible esm files vs commonjs files, namespace

* configurable truncation and prompt completion sampling

* remove unneeded util file

* remove some unneeded code

* fix patching esm vs cjs issues

* json stringify non-string chain outputs

* apikey, model, provider should no-op by default

* add some token handling logic

* review comments

* check lc_ for ignored properties
…4881)

* visit upwards parent spans

* Use correct Tracer

* break on undefined parents and test case

* change assertions order

* minor refactor
- fixs compatibility with Next.js >=v14.2.7 - 14.x
- previously there were 27 test failures
- note that this doesn't address v15.x, I'll do that in a follow up PR
- Next.js 14.2.7 broke compat when the internal headers concept was replaced with a symbol on the request object
- it was further made complicated by us relying on the removal of said internal headers
  - now that they use a symbol they just keep the data around throughout the various stages of the request
  - for that reason I'm using a `WeakSet` to track the two stages of the request
- @see AIDM-339
* updating span links

* correcting field name

* fixing links to _links
Copy link

github-actions bot commented Nov 21, 2024

Overall package size

Self size: 8.09 MB
Deduped: 94.59 MB
No deduping: 94.93 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

bengl
bengl previously approved these changes Nov 21, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Benchmark execution time: 2024-11-21 21:01:20

Comparing candidate commit 6cf775f in PR branch v5.27.0-proposal with baseline commit cbc2e02 in branch v5.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics.

@rochdev rochdev marked this pull request as ready for review November 21, 2024 21:01
@rochdev rochdev requested a review from a team as a code owner November 21, 2024 21:01
@rochdev rochdev merged commit 4c5874d into v5.x Nov 21, 2024
238 checks passed
@rochdev rochdev deleted the v5.27.0-proposal branch November 21, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants