Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DD_TAGS Parsing to Meet Spec #5213

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

khanayan123
Copy link
Collaborator

@khanayan123 khanayan123 commented Feb 6, 2025

What does this PR do?

As per spec updates DD_TAGS to handle both comma & space separated tags along with allowing empty tag values

Motivation

Config consistency across SDKs. Updated spec for DD_TAG outlined here: https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit?usp=sharing

Copy link

github-actions bot commented Feb 6, 2025

Overall package size

Self size: 8.68 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.25%. Comparing base (cde9361) to head (0edf1fc).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/tagger.js 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5213      +/-   ##
==========================================
+ Coverage   81.16%   81.25%   +0.09%     
==========================================
  Files         482      487       +5     
  Lines       21525    21715     +190     
==========================================
+ Hits        17471    17645     +174     
- Misses       4054     4070      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 6, 2025

Datadog Report

Branch report: khanayan123/dd-tags-config-consistency
Commit report: e060566
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 628 Passed, 0 Skipped, 15m 12.71s Total Time

@khanayan123 khanayan123 changed the title init Update DD_TAG Parsing to Meet Spec Feb 6, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-13 23:51:27

Comparing candidate commit 0edf1fc in PR branch khanayan123/dd-tags-config-consistency with baseline commit cde9361 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 909 metrics, 22 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-off-18

  • 🟥 max_rss_usage [+70.463MB; +101.573MB] or [+5.937%; +8.559%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-113.030MB; -64.682MB] or [-11.828%; -6.769%]

@bm1549 bm1549 changed the title Update DD_TAG Parsing to Meet Spec Update DD_TAGS Parsing to Meet Spec Feb 14, 2025
@khanayan123 khanayan123 marked this pull request as ready for review February 18, 2025 18:14
@khanayan123 khanayan123 requested a review from a team as a code owner February 18, 2025 18:14
@slimee
Copy link

slimee commented Feb 20, 2025

We would love this one to be merged!
❤️ 🙏🏽 ❤️

@khanayan123 khanayan123 marked this pull request as draft February 20, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants