Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load runtime metrics only when needed #5254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Feb 12, 2025

What does this PR do?

Lazy load runtime metrics only when needed.

Motivation

Right now when runtime metrics are disabled, the code is still loaded which impacts startup time.

Copy link

github-actions bot commented Feb 12, 2025

Overall package size

Self size: 8.76 MB
Deduped: 94.96 MB
No deduping: 95.47 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (6b97186) to head (aad7466).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5254      +/-   ##
==========================================
- Coverage   81.24%   80.95%   -0.29%     
==========================================
  Files         487      489       +2     
  Lines       21703    21826     +123     
==========================================
+ Hits        17633    17670      +37     
- Misses       4070     4156      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 12, 2025

Datadog Report

Branch report: lazy-runtime-metrics
Commit report: f4c2158
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 669 Passed, 0 Skipped, 16m 1.34s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-02-18 23:23:42

Comparing candidate commit aad7466 in PR branch lazy-runtime-metrics with baseline commit 6b97186 in branch master.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 895 metrics, 31 unstable metrics.

scenario:log-skip-log-18

  • 🟥 cpu_user_time [+17.954ms; +22.562ms] or [+5.001%; +6.285%]
  • 🟥 execution_time [+21.981ms; +24.372ms] or [+5.513%; +6.113%]

scenario:log-with-debug-18

  • 🟥 execution_time [+20.806ms; +23.712ms] or [+5.235%; +5.967%]

scenario:log-with-error-18

  • 🟥 cpu_user_time [+19.452ms; +24.504ms] or [+5.437%; +6.849%]
  • 🟥 execution_time [+22.552ms; +24.658ms] or [+5.672%; +6.202%]

scenario:log-without-log-18

  • 🟥 cpu_user_time [+19.892ms; +24.751ms] or [+5.999%; +7.464%]
  • 🟥 execution_time [+23.038ms; +24.159ms] or [+6.202%; +6.504%]

@rochdev rochdev marked this pull request as ready for review February 12, 2025 18:04
@rochdev rochdev requested a review from a team as a code owner February 12, 2025 18:04
@rochdev rochdev force-pushed the lazy-runtime-metrics branch from 6013e93 to 5e7bcdb Compare February 13, 2025 21:16
runtimeMetrics = noop
},

track: (...args) => runtimeMetrics.track(...args),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than barreling functions through like this, maybe it's better to do a prototype switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants