Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Reflect.apply instead of Function#apply #5289

Closed
wants to merge 6 commits into from

Conversation

watson
Copy link
Collaborator

@watson watson commented Feb 17, 2025

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

Copy link
Collaborator Author

watson commented Feb 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson self-assigned this Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (172bc66) to head (82fd262).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5289      +/-   ##
==========================================
+ Coverage   80.80%   80.91%   +0.11%     
==========================================
  Files         487      488       +1     
  Lines       21710    21817     +107     
==========================================
+ Hits        17542    17654     +112     
+ Misses       4168     4163       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 17, 2025

Datadog Report

Branch report: watson/eslint-plugin-unicorn
Commit report: d37861b
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 673 Passed, 0 Skipped, 15m 51.24s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2025

Benchmarks

Benchmark execution time: 2025-02-19 07:57:57

Comparing candidate commit 82fd262 in PR branch watson/eslint-plugin-unicorn with baseline commit 172bc66 in branch master.

Found 0 performance improvements and 18 performance regressions! Performance is the same for 901 metrics, 14 unstable metrics.

scenario:startup-control-everything-18

  • 🟥 cpu_user_time [+154.161ms; +177.245ms] or [+7.840%; +9.014%]
  • 🟥 execution_time [+175.189ms; +200.038ms] or [+7.785%; +8.889%]
  • 🟥 instructions [+479.1M instructions; +507.1M instructions] or [+10.188%; +10.783%]

scenario:startup-control-everything-20

  • 🟥 cpu_user_time [+159.838ms; +186.685ms] or [+8.953%; +10.457%]
  • 🟥 execution_time [+179.505ms; +203.986ms] or [+8.691%; +9.876%]
  • 🟥 instructions [+456.9M instructions; +486.4M instructions] or [+10.685%; +11.376%]

scenario:startup-control-everything-22

  • 🟥 cpu_user_time [+143.627ms; +167.091ms] or [+8.910%; +10.366%]
  • 🟥 execution_time [+158.293ms; +181.636ms] or [+8.242%; +9.457%]
  • 🟥 instructions [+461.8M instructions; +488.7M instructions] or [+10.543%; +11.157%]

scenario:startup-with-tracer-everything-18

  • 🟥 cpu_user_time [+162.214ms; +190.681ms] or [+6.465%; +7.599%]
  • 🟥 execution_time [+192.133ms; +217.379ms] or [+6.657%; +7.531%]
  • 🟥 instructions [+560.4M instructions; +581.3M instructions] or [+9.228%; +9.573%]

scenario:startup-with-tracer-everything-20

  • 🟥 cpu_user_time [+158.578ms; +182.814ms] or [+7.166%; +8.261%]
  • 🟥 execution_time [+182.057ms; +199.720ms] or [+7.062%; +7.747%]
  • 🟥 instructions [+524.1M instructions; +541.6M instructions] or [+9.503%; +9.820%]

scenario:startup-with-tracer-everything-22

  • 🟥 cpu_user_time [+144.970ms; +166.520ms] or [+6.832%; +7.848%]
  • 🟥 execution_time [+171.192ms; +190.865ms] or [+6.772%; +7.550%]
  • 🟥 instructions [+531.0M instructions; +548.3M instructions] or [+8.904%; +9.194%]

@watson watson force-pushed the watson/eslint-plugin-unicorn branch from eca3d52 to 6a805a7 Compare February 17, 2025 19:55
@watson watson changed the title Use Reflect.appply instead of Function#apply Use Reflect.apply instead of Function#apply Feb 17, 2025
@watson watson force-pushed the watson/eslint-plugin-unicorn branch from 73a8c9a to 82fd262 Compare February 19, 2025 07:49
@watson watson closed this Feb 19, 2025
@watson watson deleted the watson/eslint-plugin-unicorn branch February 19, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant