Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.38.0 proposal #5312

Merged
merged 14 commits into from
Feb 24, 2025
Merged

v5.38.0 proposal #5312

merged 14 commits into from
Feb 24, 2025

Conversation

sabrenner
Copy link
Collaborator

@sabrenner sabrenner commented Feb 24, 2025

  • [213cbe19ae] - (SEMVER-PATCH) [test optimization] Add support for Drone CI (Mario Vidal Domínguez) #5304
  • [3f1e0c57de] - (SEMVER-PATCH) fix error in http2 plugin when it was enabled after request start (Roch Devost) #3714
  • [96bb84ab2f] - (SEMVER-PATCH) [MLOB-2240] fix(openai, langchain, llmobs): OpenAI and LangChain instrumentation is ESM-compatible (Sam Brenner) #5267
  • [23abc09198] - (SEMVER-PATCH) [test optimization] Configuration parameter to disable git unshallow (Mario Vidal Domínguez) #5291
  • [4733649f4d] - (SEMVER-PATCH) Make DD_TRACE_SAMPLING_RULES consistent (Ayan Khan) #5232
  • [3582be4d1c] - (SEMVER-PATCH) Make DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED consistent (Ayan Khan) #5223
  • [0c7b06b62a] - (SEMVER-PATCH) Add bot to manage stale PRs (Brian Marks) #5300
  • [f06fb27af4] - (SEMVER-MINOR) Enable 128 bit trace id log injection by default (Ayan Khan) #5021
  • [b27a955b27] - (SEMVER-MINOR) Add pipeline to Mongodb query (Thomas Hunter II) #5299
  • [34d89b13f2] - (SEMVER-MINOR) [MLOB-2233] feat(openai, llmobs): patch _thenUnwrap of chat completion api promise instances (Sam Brenner) #5253
  • [18e840fbda] - (SEMVER-PATCH) tracing: fix http client synchronous errors causing spans to not finish (William Conti) #5294
  • [00043dff2a] - (SEMVER-PATCH) (chore) APM: Fix Bedrock Integration Refactor (Thomas Hunter II) #5278
  • [be5ecaf982] - (SEMVER-PATCH) [test optimization] Lighter init in worker thread (Juan Antonio Fernández de Alba) #5293

juan-fernandez and others added 14 commits February 24, 2025 12:04
…sh (#5294)

* ensure client http request span closes if request completely fails
…ion api promise instances (#5253)

* handle _thenUnwrap for OpenAI

* rename unwrap handler method

* add tests

* add test case for using _thenUnwrap on userland

* refactor, fix tests

* fix

* fix + todo

---------

Co-authored-by: José Mussa <[email protected]>
* enable 128 bit trace id log injection by default
* Make DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED consistent
* Make DD_TRACE_SAMPLING_RULES consistent
…rumentation is ESM-compatible (#5267)

* add module register hooks

* fix instrumentation

* re-enable tests

* file extension fix for openai

* Update packages/datadog-plugin-openai/test/integration-test/client.spec.js

* trigger ci

* change openai instrumentation

* fix for new openai version

* try fix for --loader

* name arguments

* name arguments
)

* fix error in http2 plugin when it was enabled after request start
Copy link

Overall package size

Self size: 8.77 MB
Deduped: 94.96 MB
No deduping: 95.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@1d67fe6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/datadog-instrumentations/src/openai.js 93.18% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #5312   +/-   ##
=======================================
  Coverage        ?   80.94%           
=======================================
  Files           ?      489           
  Lines           ?    21860           
  Branches        ?        0           
=======================================
  Hits            ?    17694           
  Misses          ?     4166           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: v5.38.0-proposal
Commit report: 8b63db1
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 664 Passed, 0 Skipped, 13m 35.29s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 24, 2025

Benchmarks

Benchmark execution time: 2025-02-24 17:13:20

Comparing candidate commit 186ab27 in PR branch v5.38.0-proposal with baseline commit 1d67fe6 in branch v5.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 920 metrics, 13 unstable metrics.

@sabrenner sabrenner marked this pull request as ready for review February 24, 2025 17:59
@sabrenner sabrenner requested a review from a team as a code owner February 24, 2025 17:59
@sabrenner sabrenner merged commit e493e16 into v5.x Feb 24, 2025
393 checks passed
@sabrenner sabrenner deleted the v5.38.0-proposal branch February 24, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants