Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report general tags and metrics #5335

Merged
merged 59 commits into from
Mar 7, 2025
Merged

Report general tags and metrics #5335

merged 59 commits into from
Mar 7, 2025

Conversation

IlyasShabi
Copy link
Contributor

@IlyasShabi IlyasShabi commented Feb 27, 2025

What does this PR do?

Adding general tags and metrics APPSEC-56393

  1. _dd.appsec.block.failed
  2. _dd.appsec.truncated.string_length
  3. _dd.appsec.truncated.container_size
  4. _dd.appsec.truncated.container_depth
  5. _dd.appsec.rasp.timeout
  6. _dd.appsec.waf.timeouts
  7. _dd.appsec.waf.error
  8. _dd.appsec.rasp.error

Motivation

Plugin Checklist

Additional Notes

@IlyasShabi IlyasShabi self-assigned this Feb 27, 2025
Copy link

github-actions bot commented Feb 27, 2025

Overall package size

Self size: 8.85 MB
Deduped: 95.45 MB
No deduping: 95.97 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 840.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (d603d22) to head (ca6ae33).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5335      +/-   ##
==========================================
- Coverage   80.72%   80.62%   -0.11%     
==========================================
  Files         492      490       -2     
  Lines       21902    21830      -72     
==========================================
- Hits        17681    17600      -81     
- Misses       4221     4230       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 27, 2025

Datadog Report

Branch report: ishabi/general-tags
Commit report: 5a7bb9c
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 675 Passed, 0 Skipped, 14m 35.19s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 27, 2025

Benchmarks

Benchmark execution time: 2025-03-07 10:10:07

Comparing candidate commit ca6ae33 in PR branch ishabi/general-tags with baseline commit d603d22 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 918 metrics, 15 unstable metrics.

@IlyasShabi IlyasShabi merged commit 6e11e2a into master Mar 7, 2025
396 checks passed
@IlyasShabi IlyasShabi deleted the ishabi/general-tags branch March 7, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants