Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLOB-2340] feat(vertexai): add @google-cloud/vertexai instrumentation #5369

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

sabrenner
Copy link
Collaborator

@sabrenner sabrenner commented Mar 5, 2025

What does this PR do?

Adds APM @google-cloud/vertexai instrumentation for the following functions:

  • model.generateContent/model.generateContentStream
  • chat.sendMessage/chat.sendMessageStream

For both streamed responses, spans are finished when the stream is consumed.

Motivation

Furthering auto-instrumentation for different LLM providers. A PR for submitting these span events to LLM Observability will follow.

Copy link

github-actions bot commented Mar 5, 2025

Overall package size

Self size: 8.87 MB
Deduped: 95.47 MB
No deduping: 95.98 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 840.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (45f2649) to head (544a0bd).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...adog-instrumentations/src/google-cloud-vertexai.js 85.71% 6 Missing ⚠️
.../datadog-plugin-google-cloud-vertexai/src/index.js 95.78% 4 Missing ⚠️
packages/dd-trace/src/plugins/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5369      +/-   ##
==========================================
+ Coverage   80.70%   80.76%   +0.06%     
==========================================
  Files         491      493       +2     
  Lines       21878    22026     +148     
==========================================
+ Hits        17656    17790     +134     
- Misses       4222     4236      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 5, 2025

Datadog Report

Branch report: sabrenner/vertexai
Commit report: 79bfa38
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 664 Passed, 0 Skipped, 10m 56.85s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2025

Benchmarks

Benchmark execution time: 2025-03-06 19:17:26

Comparing candidate commit 544a0bd in PR branch sabrenner/vertexai with baseline commit 45f2649 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 917 metrics, 16 unstable metrics.

@sabrenner
Copy link
Collaborator Author

working on adding config rules to system-tests for the two new config values added

@sabrenner sabrenner marked this pull request as ready for review March 7, 2025 18:51
@sabrenner sabrenner requested a review from a team as a code owner March 7, 2025 18:51
@sabrenner sabrenner requested a review from a team as a code owner March 7, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants