Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting of profiling_enabled in startup log #5383

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Mar 10, 2025

What does this PR do?

Fixes the reporting of profiling_enabled value in startup log.

Motivation

It was always reporting true due to the way the profiling.enabled value is not a boolean, but rather a three-valued string. The problem was basically that !!'false' === true

Additional Notes

Jira: PROF-11492

@szegedi szegedi requested a review from a team as a code owner March 10, 2025 11:28
Copy link

github-actions bot commented Mar 10, 2025

Overall package size

Self size: 8.87 MB
Deduped: 95.47 MB
No deduping: 95.99 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 840.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (bfed02a) to head (3976cb7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5383      +/-   ##
==========================================
- Coverage   80.76%   80.74%   -0.02%     
==========================================
  Files         492      491       -1     
  Lines       21962    21940      -22     
==========================================
- Hits        17738    17716      -22     
  Misses       4224     4224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 10, 2025

Datadog Report

Branch report: szegedi/fix-profiler-startup-log
Commit report: b343ffc
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 688 Passed, 0 Skipped, 6m 15.96s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 10, 2025

Benchmarks

Benchmark execution time: 2025-03-10 17:16:39

Comparing candidate commit 3976cb7 in PR branch szegedi/fix-profiler-startup-log with baseline commit bfed02a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 912 metrics, 21 unstable metrics.

Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test for this? :)

IlyasShabi
IlyasShabi previously approved these changes Mar 10, 2025
nsavoire
nsavoire previously approved these changes Mar 10, 2025
tlhunter
tlhunter previously approved these changes Mar 10, 2025
@szegedi szegedi dismissed stale reviews from tlhunter, nsavoire, and IlyasShabi via 3976cb7 March 10, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants