-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wrapt): remove all references to pkg_resources #7948
Conversation
BenchmarksBenchmark execution time: 2024-01-05 16:41:31 Comparing candidate commit dfb5b60 in PR branch Found 13 performance improvements and 25 performance regressions! Performance is the same for 157 metrics, 9 unstable metrics. scenario:coreapiscenario-context_with_data_listeners
scenario:coreapiscenario-context_with_data_listeners_and_all_listeners
scenario:coreapiscenario-context_with_data_no_listeners
scenario:coreapiscenario-core_dispatch_no_listeners
scenario:coreapiscenario-core_dispatch_only_all_listeners
scenario:coreapiscenario-core_dispatch_with_results_listeners_and_all_listeners
scenario:coreapiscenario-core_dispatch_with_results_only_all_listeners
scenario:coreapiscenario-get_item_exists
scenario:coreapiscenario-get_item_missing
scenario:httppropagationextract-all_styles_all_headers
scenario:httppropagationextract-empty_headers
scenario:httppropagationextract-full_t_id_datadog_headers
scenario:httppropagationextract-invalid_span_id_header
scenario:httppropagationextract-invalid_trace_id_header
scenario:httppropagationextract-large_valid_headers_all
scenario:httppropagationextract-medium_valid_headers_all
scenario:httppropagationextract-none_propagation_style
scenario:httppropagationextract-valid_headers_all
scenario:httppropagationextract-wsgi_invalid_span_id_header
scenario:httppropagationextract-wsgi_invalid_trace_id_header
scenario:httppropagationextract-wsgi_valid_headers_all
scenario:httppropagationinject-ids_only
scenario:httppropagationinject-with_all
scenario:httppropagationinject-with_dd_origin
scenario:httppropagationinject-with_priority_and_origin
scenario:httppropagationinject-with_tags
scenario:httppropagationinject-with_tags_max_size
scenario:otelspan-start-finish
scenario:sethttpmeta-all-disabled
scenario:sethttpmeta-all-enabled
scenario:sethttpmeta-obfuscation-send-querystring-disabled
scenario:sethttpmeta-obfuscation-worst-case-implicit-query
scenario:sethttpmeta-useragentvariant_exists_2
scenario:sethttpmeta-useragentvariant_exists_3
scenario:sethttpmeta-useragentvariant_not_exists_2
scenario:span-add-metrics
scenario:span-start-finish-telemetry
scenario:span-start-finish-traceid128
|
Has this been resolved in wrapt itself? Can we resolve it by vendoring a new version, or even adding wrapt as a dependency? |
Nope: https://github.com/GrahamDumpleton/wrapt/blob/develop/src/wrapt/importer.py#L94. We could make the upstream contribution, release a new version then vendor it but that seems like a pain. |
@mabdinur I see your point. We can make this change here and also contribute upstream. We'll want to run all tests given this change. |
We may need to bump pybind11: pybind/pybind11#4941 |
Resolves: #7918
Checklist
changelog/no-changelog
.Reviewer Checklist
@DataDog/security-design-and-guidance
.