Improve variable naming for Instrumentation.gateway.push return

DataDog · Jan 20, 2025 · 11512de · 11512de
1 parent 15afd41
commit 11512de
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/lib/datadog/appsec/contrib/graphql/appsec_trace.rb b/lib/datadog/appsec/contrib/graphql/appsec_trace.rb
@@ -16,7 +16,7 @@ def execute_multiplex(multiplex:)
 
             gateway_multiplex = Gateway::Multiplex.new(multiplex)
 
-            multiplex_return, = Instrumentation.gateway.push('graphql.multiplex', gateway_multiplex) do
+            multiplex_return, _gateway_multiplex = Instrumentation.gateway.push('graphql.multiplex', gateway_multiplex) do
               super
             end
 

diff --git a/lib/datadog/appsec/contrib/rack/request_body_middleware.rb b/lib/datadog/appsec/contrib/rack/request_body_middleware.rb
@@ -25,7 +25,7 @@ def call(env)
 
             http_response = nil
             interrupt_params = catch(::Datadog::AppSec::Ext::INTERRUPT) do
-              http_response, = Instrumentation.gateway.push('rack.request.body', Gateway::Request.new(env)) do
+              http_response, _request = Instrumentation.gateway.push('rack.request.body', Gateway::Request.new(env)) do
                 @app.call(env)
               end
 

diff --git a/lib/datadog/appsec/contrib/rack/request_middleware.rb b/lib/datadog/appsec/contrib/rack/request_middleware.rb
@@ -77,7 +77,7 @@ def call(env)
             gateway_response = nil
 
             interrupt_params = catch(::Datadog::AppSec::Ext::INTERRUPT) do
-              http_response, = Instrumentation.gateway.push('rack.request', gateway_request) do
+              http_response, _gateway_request = Instrumentation.gateway.push('rack.request', gateway_request) do
                 @app.call(env)
               end
 

diff --git a/lib/datadog/appsec/contrib/rails/patcher.rb b/lib/datadog/appsec/contrib/rails/patcher.rb
@@ -81,7 +81,7 @@ def process_action(*args)
 
               gateway_request = Gateway::Request.new(request)
 
-              http_response, = Instrumentation.gateway.push('rails.request.action', gateway_request) do
+              http_response, _gateway_request = Instrumentation.gateway.push('rails.request.action', gateway_request) do
                 super
               end
 

diff --git a/lib/datadog/appsec/contrib/sinatra/patcher.rb b/lib/datadog/appsec/contrib/sinatra/patcher.rb
@@ -61,7 +61,7 @@ def dispatch!
 
             gateway_request = Gateway::Request.new(env)
 
-            request_return, = Instrumentation.gateway.push('sinatra.request.dispatch', gateway_request) do
+            request_return, _gateway_request = Instrumentation.gateway.push('sinatra.request.dispatch', gateway_request) do
               super
             end
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,7 @@ def execute_multiplex(multiplex:) @@
                 gateway_multiplex = Gateway::Multiplex.new(multiplex)
-                multiplex_return, = Instrumentation.gateway.push('graphql.multiplex', gateway_multiplex) do
+                multiplex_return, _gateway_multiplex = Instrumentation.gateway.push('graphql.multiplex', gateway_multiplex) do
                   super
                 end
@@ Expand Down @@