Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PROF-10124] Lower value used to clamp very high allocation profiling…
… weights **What does this PR do?** This PR lowers the profiling internal constant `MAX_ALLOC_WEIGHT` from 65535 to 10000. This value is used when clamping very high allocation profiling weights. Aka: Each allocation sample taken by the profiler has a weight assigned to it; this weight is clamped (e.g. limited to) this maximum value. The remaining weight is assigned to a separate "skipped samples" placeholder (see #3792). **Motivation:** Very large weights on samples can produce biased results; by lowering the maximum we reduce the maximum bias that can ever be introduced. **Additional Notes:** I've gathered data from a number of apps when choosing this value, see <https://docs.google.com/document/d/1lWLB714wlLBBq6T4xZyAc4a5wtWhSmr4-hgiPKeErlA/edit> for details (Datadog-only link, sorry!). **How to test the change?** The tests for #3792 also cover this change (although the changes are otherwise independent).
- Loading branch information