Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Draft) [NO-TICKET] Update crashtracker with libdatadog 15 breaking changes #4255

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

(Draft) [NO-TICKET] Update crashtracker with libdatadog 15 breaking changes #4255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ext/libdatadog_api/crashtracker.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static VALUE _native_start_or_update_on_fork(int argc, VALUE *argv, DDTRACE_UNUS
.optional_stdout_filename = {},
};

ddog_crasht_Result result =
ddog_VoidResult result =
action == start_action ?
ddog_crasht_init(config, receiver_config, metadata) :
ddog_crasht_update_on_fork(config, receiver_config, metadata);
Expand All @@ -108,17 +108,17 @@ static VALUE _native_start_or_update_on_fork(int argc, VALUE *argv, DDTRACE_UNUS
ddog_endpoint_drop(endpoint);
// }} End of exception-free zone to prevent leaks

if (result.tag == DDOG_CRASHT_RESULT_ERR) {
if (result.tag == DDOG_VOID_RESULT_ERR) {
rb_raise(rb_eRuntimeError, "Failed to start/update the crash tracker: %"PRIsVALUE, get_error_details_and_drop(&result.err));
}

return Qtrue;
}

static VALUE _native_stop(DDTRACE_UNUSED VALUE _self) {
ddog_crasht_Result result = ddog_crasht_shutdown();
ddog_VoidResult result = ddog_crasht_shutdown();

if (result.tag == DDOG_CRASHT_RESULT_ERR) {
if (result.tag == DDOG_VOID_RESULT_ERR) {
rb_raise(rb_eRuntimeError, "Failed to stop the crash tracker: %"PRIsVALUE, get_error_details_and_drop(&result.err));
}

Expand Down
Loading