DEBUG-3317 report probe status errored if probe fails to instrument #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
spec/datadog/di/integration/everything_from_remote_config_spec.rb
Outdated
Show resolved
Hide resolved
spec/datadog/di/integration/everything_from_remote_config_spec.rb
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 22092 Passed, 1477 Skipped, 5m 8.94s Total Time |
BenchmarksBenchmark execution time: 2025-01-22 19:47:36 Comparing candidate commit b0f954d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
marcotc
approved these changes
Jan 21, 2025
…d but not in code tracker registry
p-datadog
force-pushed
the
di-not-in-registry-integration-test
branch
from
91a1c3a to
b0f954d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reports probe status as errored if the probe fails to instrument.
Motivation:
Manual testing revealed that failure to instrument due to code not being in code tracker did not update UI with probe status.
Change log entry
Yes: fix UI notifications when dynamic instrumentation probes fail to instrument
Additional Notes:
How to test the change?
Tests are included