-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action handling to AppSec ActiveRecord instrumentation #4321
Add action handling to AppSec ActiveRecord instrumentation #4321
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22494 Passed, 1489 Skipped, 5m 8.27s Total Time New Flaky Tests (1)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4321 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.02%
==========================================
Files 1367 1368 +1
Lines 82864 82916 +52
Branches 4209 4209
==========================================
+ Hits 80985 81027 +42
- Misses 1879 1889 +10 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-01-27 15:28:32 Comparing candidate commit 371eab8 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:tracing - 10 span trace - no writer
scenario:tracing - 100 span trace - no writer
scenario:tracing - Propagation - Datadog
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the test suite needs more love
spec/datadog/appsec/contrib/active_record/mysql2_adapter_spec.rb
Outdated
Show resolved
Hide resolved
spec/datadog/appsec/contrib/active_record/mysql2_adapter_spec.rb
Outdated
Show resolved
Hide resolved
spec/datadog/appsec/contrib/active_record/mysql2_adapter_spec.rb
Outdated
Show resolved
Hide resolved
spec/datadog/appsec/contrib/active_record/mysql2_adapter_spec.rb
Outdated
Show resolved
Hide resolved
spec/datadog/appsec/contrib/active_record/postgresql_adapter_spec.rb
Outdated
Show resolved
Hide resolved
spec/datadog/appsec/contrib/active_record/sqlite3_adapter_spec.rb
Outdated
Show resolved
Hide resolved
f6d950e
to
2414459
Compare
38dd76f
to
371eab8
Compare
What does this PR do?
This PR adds action handling to AppSec
ActiveRecord
instrumentation.Motivation:
Currently we are only monitoring WAF events for SQLi.
Change log entry
Yes. AppSec: Add reporting of stack trace when SQL Injection attack is detected.
Additional Notes:
None.
How to test the change?
CI and app generator.