Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DOCS-3234) Create AWS manual setup guide #13963

Merged
merged 9 commits into from
May 23, 2022
Merged

(DOCS-3234) Create AWS manual setup guide #13963

merged 9 commits into from
May 23, 2022

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented May 6, 2022 •
edited
Loading

What does this PR do?

Adds a guide for manually setting up the AWS integration.

Motivation

DOCS-3234

Preview

https://docs-staging.datadoghq.com/bryce/create-aws-manual-setup-guide/integrations/guide/aws-manual-setup/

Additional Notes

Once merged, will update the main AWS docs to point to this guide.

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@buraizu buraizu added the WORK IN PROGRESS No review needed, it's a wip ;) label May 6, 2022
@buraizu buraizu requested a review from a team as a code owner May 6, 2022 19:27
@github-actions github-actions bot added Guide Content impacting a guide integrations Content changed in the integrations folder labels May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Preview links (active after the build_preview check completes):
https://docs-staging.datadoghq.com/bryce/create-aws-manual-setup-guide/integrations/guide/
https://docs-staging.datadoghq.com/bryce/create-aws-manual-setup-guide/integrations/guide/aws-manual-setup

warrierr
warrierr requested changes May 11, 2022
View reviewed changes
Copy link
Contributor

@warrierr warrierr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this guide, let's make sure to update the main AWS integrations docs page: https://docs-staging.datadoghq.com/bryce/create-aws-manual-setup-guide/integrations/amazon_web_services/?tab=roledelegation#setup

to link to this

content/en/integrations/guide/_index.md Outdated Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Outdated Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Outdated Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Show resolved Hide resolved
warrierr
warrierr requested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@warrierr warrierr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buraizu my final comments. This LGTM after those are addressed.

content/en/integrations/guide/_index.md Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Outdated Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Outdated Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Outdated Show resolved Hide resolved
@buraizu buraizu requested a review from warrierr May 20, 2022 23:57
@buraizu buraizu removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 20, 2022
warrierr
warrierr approved these changes May 21, 2022
View reviewed changes
Copy link
Contributor

@warrierr warrierr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apigirl
apigirl approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small things!

content/en/integrations/guide/aws-manual-setup.md Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Outdated Show resolved Hide resolved
content/en/integrations/guide/aws-manual-setup.md Show resolved Hide resolved
@buraizu buraizu merged commit e6662f5 into master May 23, 2022
@buraizu buraizu deleted the bryce/create-aws-manual-setup-guide branch May 23, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrierr warrierr warrierr approved these changes

@apigirl apigirl apigirl approved these changes

Assignees
No one assigned
Labels
Guide Content impacting a guide integrations Content changed in the integrations folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buraizu @warrierr @apigirl