Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLO page updates #17467

Merged
merged 7 commits into from
Apr 7, 2023
Merged

SLO page updates #17467

merged 7 commits into from
Apr 7, 2023

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Mar 29, 2023 •
edited
Loading

What does this PR do?

  • Updated slo list widget and redirect internally
  • Added sort by status and error budget
  • SLO notebook template in the template gallery

Motivation

https://datadoghq.atlassian.net/browse/DOCS-4704

Additional Notes

Do Not Merge. Pending PM Review.

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@estherk15
SLO page updates
0222c8f 
  - Updated slo list widget and redirect internally (#6)
  - Added sort by status and error budget (#2)
  - Added summary view (#3)
@estherk15 estherk15 added the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 29, 2023
@estherk15 estherk15 requested a review from a team as a code owner March 29, 2023 14:30
@github-actions github-actions bot added the Images Images are added/removed with this PR label Mar 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@estherk15 estherk15 requested a review from kaixintai March 29, 2023 17:25
@estherk15 estherk15 force-pushed the esther/docs-4704-slo-updates branch from ac813ae to 1cef465 Compare April 5, 2023 18:36
@github-actions github-actions bot removed the Images Images are added/removed with this PR label Apr 5, 2023
@estherk15 estherk15 removed the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 5, 2023
kaixintai
kaixintai approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@kaixintai kaixintai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for all your work here Esther!

Teams is the only thing that's still being rolled out. It's available in EU, US3, and US5, just not US1 and Fed.

@estherk15
Apply suggestions from code review
5e9867e 
Removed Teams - will add in a separate PR
@estherk15 estherk15 merged commit 0cf1926 into master Apr 7, 2023
@estherk15 estherk15 deleted the esther/docs-4704-slo-updates branch April 7, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaixintai kaixintai kaixintai approved these changes

@urseberry urseberry urseberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estherk15 @kaixintai @urseberry