Fix default values of logs_config.open_files_limit
#28039
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the hardcoded default value and instead provide a link to the config template file. Added instructions on how users can check the default value for their Agent version. This prevents discrepancies in future updates.
Preview links (active after the
|
t5kaji
commented
Mar 8, 2025
| **Note**: Increasing the tailed logs files limit might increase the resource consumption of the Agent. | ||
|
|
||
| [1]: https://github.com/DataDog/datadog-agent/blob/369a8dbb39dc6e8601d82c8f43caaaf88d6a0a55/pkg/config/config_template.yaml#L987-L993 |
There was a problem hiding this comment.
This commit hash points to the latest update to this file as of now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
This PR fixes a discrepancy in the documented default value of
logs_config.open_files_limitfor Windows. The documentation incorrectly stated200, while the actual default is now500.Additionally, this PR removes the hardcoded default value and instead provides a link to the config template file. This ensures accuracy and prevents similar discrepancies in future updates.
I’d appreciate any feedback on this change 🙏
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes