Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with node-sass #6508

Merged
merged 1 commit into from
Jan 28, 2020
Merged

fix issue with node-sass #6508

merged 1 commit into from
Jan 28, 2020

Conversation

zbayoff
Copy link
Contributor

@zbayoff zbayoff commented Jan 27, 2020

What does this PR do?

seems running the corp-ci image now gives an error due to an updated node-sass package. Locking the version to 4.13.0 fixes this. https://gitlab.ddbuild.io/DataDog/corp-ci/-/jobs/24385167

Preview link

http://docs-staging.datadoghq.com/zach/update-node-sass

@zbayoff zbayoff requested a review from a team as a code owner January 27, 2020 18:55
@zbayoff zbayoff added the Architecture Everything related to the Doc backend label Jan 27, 2020
@l0k0ms l0k0ms merged commit 459c2e1 into master Jan 28, 2020
@l0k0ms l0k0ms deleted the zach/update-node-sass branch January 28, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsollecito nsollecito nsollecito approved these changes

@l0k0ms l0k0ms l0k0ms approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbayoff @nsollecito @l0k0ms