Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Client side aggregation #174

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

ogaca-dd
Copy link
Contributor

Document Client side aggregation

Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some initial feedback and comments. This will need a full re review from someone on the docs team once we have a bit more context

## Client side aggregation

By default, metrics for basic types (gauges, counts, sets) are aggregated before they are sent. For example, instead of sending 3 times `my_metric:10|c|#tag1:value`, DogStatsD client sends `my_metric:30|c|#tag1:value` once.
For more technical details about how client-side aggregation works see #134.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is #131 in this context?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#134 is the link to the PR that introduced client side aggregation.
Note: Github will create a full link from #134

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

The aggregation window is 2s by default and can be changed through [FlushInterval](https://github.com/DataDog/dogstatsd-csharp-client/blob/7.0.0/src/StatsdClient/ClientSideAggregationConfig.cs#L18). Note that the aggregation window on the Agent side is 10s for DogStatsD metrics. So for example, setting an aggregation window of 3s in the client produces a spike in your dashboard every 30s for counts metrics (as the third 10s bucket on the Agent is received 4 samples from the client).

To disable client-side aggregation set [ClientSideAggregation](https://github.com/DataDog/dogstatsd-csharp-client/blob/7.0.0/src/StatsdClient/StatsdConfig.cs#L141) to `null`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same link feedback

ogaca-dd and others added 2 commits December 3, 2021 12:43
Co-authored-by: Kaylyn <[email protected]>
Co-authored-by: Kaylyn <[email protected]>
@ogaca-dd ogaca-dd requested a review from apigirl December 3, 2021 11:49
@ogaca-dd ogaca-dd merged commit 9a8dab4 into master Dec 10, 2021
@ogaca-dd ogaca-dd deleted the olivierg/doc-client-side-aggregation branch December 10, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants