-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mmh3.hash64
unicode exception with python2
#10685
Conversation
Required for #10637 The test suite improvements in that PR which expand Windows test coverage are what surfaced this bug.
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, is it possible to add a test case to ensure this works?
mmh3.hash64
unicode exception with python2 on Windowsmmh3.hash64
unicode exception with python2
Yes, I just added a test case with a unicode character. |
What does this PR do?
Fixes
mmh3.hash64
UnicodeEncodeError when the query contained non-ascii characters in python2.Motivation
Fix bug originally surfaced while working on #10637
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached